fix: respect pagination URLs when fetching GitHub releases#179
Merged
GideonBear merged 2 commits intojaemk:masterfrom Apr 10, 2026
Merged
fix: respect pagination URLs when fetching GitHub releases#179GideonBear merged 2 commits intojaemk:masterfrom
GideonBear merged 2 commits intojaemk:masterfrom
Conversation
Don't unconditionally append `?per_page=100` to the fetch URL. Pagination URLs from GitHub's Link header may already include query parameters; the code now checks for a '?' and uses the URL as-is if present, otherwise it appends `?per_page=100`. This prevents malformed requests and preserves pagination links.
GideonBear
reviewed
Apr 10, 2026
GideonBear
changed the title
GideonBear
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't unconditionally append
?per_page=100to the fetch URL. Pagination URLs from GitHub's Link header may already include query parameters; the code now checks for a '?' and uses the URL as-is if present, otherwise it appends?per_page=100. This prevents malformed requests and preserves pagination links.see #178