Repository navigation
Improve and package NetDiagram-PS for distribution - #7
Merged
Merged
Conversation
- Invoke-SnmpWalk hard-coded snmpwalk.exe, so SNMP discovery never worked
on the macOS/Linux platforms added in 1.1.0. Resolve snmpwalk or
snmpwalk.exe from PATH instead.
- Test-IPInSubnet threw an OverflowException on every non-zero prefix
because [uint32]0xFFFFFFFF parses as int -1. Compute the mask in UInt64
and truncate. This also silently broke CIDR matching in Get-SnmpNeighbors.
- Raise the module floor to PowerShell 7.4: Test-Connection -TimeoutSeconds
(used by Test-DeviceReachability and the wizard) only exists in 7.4+, so
the advertised 7.0 minimum errored at runtime.
- Add CompatiblePSEditions = @('Core') to the manifest and bump to 1.2.0.
Co-Authored-By: wren <wren@agent.local>
- Version assertion now reads the manifest instead of a stale hard-coded string (the 1.0.1 assertion failed against the 1.1.0 manifest). - Build the module path with Join-Path (no literal backslash) so the suite runs on macOS/Linux as well as Windows. - Add tests for Get-MACVendor, Get-CommonSNMPStrings, Resolve-IPHostname, Invoke-SnmpWalk (missing-binary path), and the private Test-IPInSubnet helper. These caught the subnet-mask overflow fixed in the prior commit. - Add GitHub Actions workflow: Pester on Windows/macOS/Linux plus PSScriptAnalyzer (fails on Error severity). Co-Authored-By: wren <wren@agent.local>
- LICENSE copyright holder and README license section now match the manifest (MIT, Jacob Yoby) instead of contradicting it. - README documents installation (Gallery + clone) and the 7.4 requirement. - STRUCTURE.md version corrected to match the manifest. - CHANGELOG entry for 1.2.0. - Add PUBLISHING.md describing the Publish-Module release path and a release checklist. Co-Authored-By: wren <wren@agent.local>
jacobyoby
marked this pull request as ready for review
July 30, 2026 15:23
jacobyoby
added a commit
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares NetDiagram-PS for possible PowerShell Gallery distribution: fixes real bugs, expands tests, adds CI, and aligns docs. All 36 Pester tests pass on PowerShell 7.6 (macOS); PSScriptAnalyzer reports no Error-severity findings.
Bug fixes
Invoke-SnmpWalkhard-codedsnmpwalk.exe, so SNMP discovery never worked on the platforms the 1.1.0 release advertised. Now resolvessnmpwalk/snmpwalk.exefrom PATH.Test-IPInSubnetthrewOverflowExceptionon every non-zero prefix ([uint32]0xFFFFFFFFparses as int-1). Fixed with UInt64 math. This had silently broken CIDR matching inGet-SnmpNeighbors. Caught by a newly added test.Test-Connection -TimeoutSecondsis 7.4+, but the manifest advertised 7.0, so reachability calls errored on 7.0–7.3. Raised the minimum to 7.4 and addedCompatiblePSEditions = @('Core').1.0.1; module path used a Windows-only literal backslash. Both fixed so the suite is green and cross-platform.Packaging / distribution
Get-MACVendor,Get-CommonSNMPStrings,Resolve-IPHostname,Invoke-SnmpWalk,Test-IPInSubnet).PUBLISHING.mdwith thePublish-Modulepath and a release checklist.Not done here (Jacob's calls)