Repository navigation
Fix Codex review findings; prep NetDiagram-PS 1.3.0 for Gallery - #8
Merged
Merged
Conversation
- Get-SnmpNeighbors: query untested nodes (Reachable=$null) by default so the import-then-discover workflow works; add -OnlyReachable opt-in switch. - Invoke-SnmpWalk: redact community from verbose output (-c ****); validate Version/TargetIP/OID and reject values starting with '-'; restrict binary resolution to -CommandType Application; document process-list exposure. - Harden LLDP/CDP parsing (value-only, octet-validated, Hex-STRING aware, self-loop guard) and document it as best-effort. - Export-DrawIO: de-duplicate node IPs; parent nodes into their matching subnet container via Test-IPInSubnet, laying unmatched nodes out below the containers. - Invoke-PortScan: ValidateRange on ports (1-65535) and timeout (1-60000); drop TCP 161 from defaults (SNMP is UDP). - Resolve-IPHostname: honor -TimeoutSeconds via async DNS with a bounded wait. Co-Authored-By: wren <wren@users.noreply.github.com>
- Manifest ModuleVersion 1.2.0 -> 1.3.0 with review-summary ReleaseNotes. - Add CHANGELOG 1.3.0 entry. - README: require 7.4+ (was 7.0+); document SNMP eligibility, -OnlyReachable, best-effort LLDP parsing, and community redaction/process-list caveat. - STRUCTURE: update to 1.3.0/2026-07-30, add .github CI to the layout, and describe the CI workflow. Co-Authored-By: wren <wren@users.noreply.github.com>
- Replace the /24 assumption with real IPv4 CIDR host enumeration derived from the interface prefix; cap Full scans of large subnets at a /22 (1022 hosts) with a warning; extract Get-SubnetScanTarget for testability. - Fix Windows-separator Join-Path for the module path. Co-Authored-By: wren <wren@users.noreply.github.com>
Co-Authored-By: wren <wren@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Codex review so NetDiagram-PS is clean to publish to the PowerShell Gallery. Module bumped to 1.3.0.
Fixed
High
Get-SnmpNeighborsonly queriedReachable -eq $true, but imported inventory hasReachable = $null. Untested nodes are now eligible by default; added-OnlyReachableopt-in. The documented import-then-discover workflow now works end to end.Invoke-SnmpWalknow redacts-c <community>to-c ****. Process-list exposure documented as a known limitation.Hex-STRINGmanagement addresses, and skips self-loops. Documented as best-effort MVP in help + README.examples/New-NetworkDiagram.ps1now derives hosts from the real CIDR prefix and caps Full scans of large subnets at a /22 (1022 hosts) with a warning.Medium
Join-Pathfixed in the wizard module path.Invoke-SnmpWalkvalidates Version (v1/v2c/v3), TargetIP (IPv4/FQDN), OID (dotted-decimal), rejects args starting with-, and restricts binary resolution to-CommandType Application.Invoke-PortScanvalidates ports (1-65535) and timeout (1-60000); removed TCP 161 from defaults (SNMP is UDP).Export-DrawIOde-duplicates node IPs (no more duplicate mxCell ids).Export-DrawIOparents nodes into their matching subnet container viaTest-IPInSubnet; unmatched nodes laid out below the containers.Low
Resolve-IPHostnamenow honors-TimeoutSeconds(async DNS); previously ignored.Tests
Behavior change to note