Repository navigation
Select the routed interface in the discovery wizard - #52
Merged
Merged
Conversation
12 tasks
Bound reverse DNS during wizard discovery
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wizard previously scanned the first IPv4 address returned by the operating system while displaying the gateway from a separate default-route lookup. With VPNs, bridges, or multiple adapters, those values could describe different networks.
This change retains interface names and indexes across Windows, macOS, and Linux discovery. It selects the interface attached to the active default route, supports an explicit
-InterfaceNamename or numeric index, and stops with an actionable error when multiple adapters cannot be resolved safely. An explicitly selected non-default Unix interface does not inherit an unrelated gateway.Fixture tests cover Windows route-index selection, macOS and Linux parsing, explicit selection, missing routes, and unavailable selectors. The README documents the override.
Validation:
git diff --checkpassed. This branch was rebased onto currentmainafter #23 merged. GitHub Actions provides three-OS Pester and analyzer validation.Closes #15