Skip to content

Release build fixes #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonihele merged 2 commits into from
Jan 10, 2026
Merged

Release build fixes #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f3689c
Remove the platform independent fix (handled by NBPackage)
tonihele Jan 10, 2026
0e76499
Update license years
tonihele Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
run: ./gradlew overrideHarness -Ptag_name=${{ github.ref_name }}
- name: Build Installers
run: ant -Dstorepass="$NBM_SIGN_PASS" -Dpack200.enabled=false set-spec-version build-zip unset-spec-version
- name: Fix Platform Independent Build
run: ./gradlew fixPlatformIndependent -Ptag_name=${{ github.ref_name }}
- name: Download JDKs for the installers
run: bash download-jdks.sh
working-directory: installers
Expand Down
36 changes: 0 additions & 36 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,42 +643,6 @@ tasks.register('cleanSdk') {
}
}

tasks.register('extractPlatformIndependent', Copy) {
from zipTree('dist/jmonkeyplatform.zip')
into "dist/temp/"

exclude("jmonkeyplatform/etc/jmonkeyplatform.conf")
}

tasks.register('patchPlatformIndependent', Copy) {
dependsOn extractPlatformIndependent
from zipTree('dist/jmonkeyplatform.zip')
into "dist/temp/"

include("jmonkeyplatform/etc/jmonkeyplatform.conf")

filter { String line ->
line.startsWith('jdkhome=') ? '#jdkhome="/path/to/jdk"' : line
}

doLast {
delete(file('dist/jmonkeyplatform.zip'))
}
}

tasks.register('fixPlatformIndependent', Zip) {
dependsOn patchPlatformIndependent
description = "We compile our installers with the bundled jdk, but the platform independent zip doesn't have the jdk. For this we need to change the jmonkeyplatform.zip after building the installers to not have a jdk bundled"

from 'dist/temp'
archiveFileName = 'jmonkeyplatform.zip'
destinationDirectory = file('dist')

doLast {
delete("dist/temp")
}
}

wrapper {
gradleVersion = '9.2.1'
}
Expand Down
2 changes: 1 addition & 1 deletion installers/windows-x64/licenses-sdk.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
******************************************************************************
JME LICENSE
******************************************************************************
Copyright (c) 2003-2025 jMonkeyEngine
Copyright (c) 2003-2026 jMonkeyEngine
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
2 changes: 1 addition & 1 deletion license-jme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2003-2025 jMonkeyEngine
Copyright (c) 2003-2026 jMonkeyEngine
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down