Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the fixPlatformIndependent Gradle task and related pipeline step that was causing issues with Linux releases by breaking file permissions during repackaging. The NBPackage now handles the platform-independent build directly, making these workarounds unnecessary.
Changes:
- Removed three Gradle tasks (
extractPlatformIndependent,patchPlatformIndependent,fixPlatformIndependent) that are no longer needed - Removed the "Fix Platform Independent Build" step from the GitHub Actions release workflow
- Updated copyright years from 2025 to 2026 in license files
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| license-jme.txt | Updated copyright year to 2026 |
| installers/windows-x64/licenses-sdk.txt | Updated copyright year to 2026 |
| build.gradle | Removed obsolete Gradle tasks for platform-independent build fixing |
| .github/workflows/release.yml | Removed workflow step that called the removed Gradle task |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fixPlatformIndependentis no longer needed as the NBPackage does this for us. It also broke the Linux releases as the repackaging didn't preserve the file permissions. By default they should be preserved but somehow this was not the case. I don't know whether that is related to the Gradle update or what. Either way this shenanigans is not needed anymore.Linux release seems to be ok now. Windows installer is not too ok still.