Skip to content

🎨 Palette: Improve Dialog accessibility #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanleekk wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

🎨 Palette: Improve Dialog accessibility #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/src/components/ui/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,21 @@ export function Dialog({ isOpen, onClose, children }: DialogProps) {
<div
className="fixed inset-0 bg-base-900/40 backdrop-blur-sm transition-opacity animate-in fade-in duration-200"
onClick={onClose}
aria-hidden="true"
/>

{/* Modal */}
<div
role="dialog"
aria-modal="true"
className="relative w-full max-w-lg rounded-2xl bg-white dark:bg-base-900 p-6 shadow-2xl transition-all animate-in zoom-in-95 duration-200 border border-base-100 dark:border-base-800"
>
<button
onClick={onClose}
className="absolute right-4 top-4 rounded-full p-2 text-base-400 hover:bg-base-50 dark:hover:bg-base-800 hover:text-base-600 dark:hover:text-base-100 transition-colors"
aria-label="Close dialog"
>
<X className="h-5 w-5" />
<X className="h-5 w-5" aria-hidden="true" />
</button>
{children}
</div>
Expand Down