🎨 Palette: Improve Dialog accessibility#196
Conversation
Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added standard WAI-ARIA roles and attributes to the shared
Dialogcomponent.🎯 Why: To ensure screen readers properly interpret the modal container as a dialog, prevent the background overlay and graphical
Xicon from creating noise, and provide an explicit text label for the icon-only close button.📸 Before/After: The visual appearance remains completely unchanged.
♿ Accessibility:
role="dialog"andaria-modal="true"to the inner modal container.aria-hidden="true"to the decorative backdrop overlay.aria-label="Close dialog"to the close<button>.aria-hidden="true"to the purely decorative<X>SVG icon.PR created automatically by Jules for task 4740460228249345061 started by @ivanleekk