Skip to content

🎨 Palette: Improve Dialog accessibility#196

Open
ivanleekk wants to merge 1 commit into
devfrom
palette/dialog-accessibility-4740460228249345061
Open

🎨 Palette: Improve Dialog accessibility#196
ivanleekk wants to merge 1 commit into
devfrom
palette/dialog-accessibility-4740460228249345061

Conversation

@ivanleekk

Copy link
Copy Markdown
Owner

💡 What: Added standard WAI-ARIA roles and attributes to the shared Dialog component.
🎯 Why: To ensure screen readers properly interpret the modal container as a dialog, prevent the background overlay and graphical X icon from creating noise, and provide an explicit text label for the icon-only close button.
📸 Before/After: The visual appearance remains completely unchanged.
♿ Accessibility:

  • Added role="dialog" and aria-modal="true" to the inner modal container.
  • Added aria-hidden="true" to the decorative backdrop overlay.
  • Added aria-label="Close dialog" to the close <button>.
  • Added aria-hidden="true" to the purely decorative <X> SVG icon.

PR created automatically by Jules for task 4740460228249345061 started by @ivanleekk

Co-authored-by: ivanleekk <84584280+ivanleekk@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant