Allow using user bookmarks list as question source#799
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
+ Coverage 40.27% 40.28% +0.01%
==========================================
Files 547 547
Lines 23806 23814 +8
Branches 2896 2898 +2
==========================================
+ Hits 9587 9593 +6
- Misses 13317 13320 +3
+ Partials 902 901 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
to reflect changes to this endpoint
axlewin
approved these changes
Jun 17, 2026
axlewin
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
R.E. the test that was commented out: I've made some minor changes to repurpose it to test the searchBookmarks param instead. If you're happy with that, this can be merged.
Contributor
Author
|
Amazing, thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In doing so, reworks the ID field in the
/questionsendpoint.bookmarks?: booleanparam has been added, which repurposes the functionality of the old ID param to send to ES a list of content IDs – namely those that have been bookmarked – to search within. This allows us to reuse the filtering logic we have for other uses of the/questionsendpoint inside a bookmarks search.The test that is entirely commented out I was not sure what to do with – perhaps we can repurpose it, but given that it requires specifically the list functionality of the old ID param which has no equivalent any longer, perhaps we can also just remove it.