Use modified /questions endpoint to search bookmarks#2208
Merged
Conversation
(as opposed to relying on front-end filtering of the entire list)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2208 +/- ##
==========================================
+ Coverage 43.54% 43.55% +0.01%
==========================================
Files 597 597
Lines 25217 25209 -8
Branches 7478 8375 +897
==========================================
Hits 10981 10981
+ Misses 14187 14179 -8
Partials 49 49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
axlewin
approved these changes
Jun 17, 2026
axlewin
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Not sure if you want to hold off on merging this until the corresponding API changes have been through a release cycle; maybe since this'll only affect people with the feature flag on we don't need to wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than relying on front-end filtering of the entire list of bookmarks, instead use the modified
/questionsendpoint to allow our ES filtering to run this in precisely the same manner as for other uses of the endpoint.