Skip to content

Use modified /questions endpoint to search bookmarks#2208

Merged
jacbn merged 2 commits into
mainfrom
feature/bookmarks-filtering-in-builder
Jun 19, 2026
Merged

Use modified /questions endpoint to search bookmarks#2208
jacbn merged 2 commits into
mainfrom
feature/bookmarks-filtering-in-builder

Conversation

@jacbn

@jacbn jacbn commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Rather than relying on front-end filtering of the entire list of bookmarks, instead use the modified /questions endpoint to allow our ES filtering to run this in precisely the same manner as for other uses of the endpoint.

jacbn added 2 commits June 12, 2026 09:50
(as opposed to relying on front-end filtering of the entire list)
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.55%. Comparing base (a1ee401) to head (39dd16f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...components/elements/modals/QuestionSearchModal.tsx 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
+ Coverage   43.54%   43.55%   +0.01%     
==========================================
  Files         597      597              
  Lines       25217    25209       -8     
  Branches     7478     8375     +897     
==========================================
  Hits        10981    10981              
+ Misses      14187    14179       -8     
  Partials       49       49              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axlewin axlewin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Not sure if you want to hold off on merging this until the corresponding API changes have been through a release cycle; maybe since this'll only affect people with the feature flag on we don't need to wait.

@jacbn jacbn merged commit 2321dd9 into main Jun 19, 2026
10 checks passed
@jacbn jacbn deleted the feature/bookmarks-filtering-in-builder branch June 19, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants