Skip to content

fix(workspace): deterministic bootstrap pane id to stop hydration mismatch #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rotecodefraktion wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(workspace): deterministic bootstrap pane id to stop hydration mismatch #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/stores/workspaceStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,14 @@ function makePane(): PaneState {
return { id: uuidv4(), tabs: [], activeTabId: null }
}

// Deterministic id for the very first pane the store hands out before persist
// rehydration. A random uuid here would differ between the SSR render and the
// client's first render, tripping a React hydration mismatch on the editor
// tabpanel `id` (editor-tabpanel-${pane.id}). After rehydration the persisted
// panes (with their own uuids) replace this one, client-side only — no SSR
// comparison — so a fixed bootstrap id is safe and unique among panes.
const BOOTSTRAP_PANE_ID = '__bootstrap-pane__'

const DEFAULT_SPLIT_RATIO = 0.5

function leaf(paneId: string): LayoutNode {
Expand Down Expand Up @@ -575,7 +583,7 @@ export function migrateWorkspace(persisted: unknown, version: number): {
export const useWorkspaceStore = create<WorkspaceState>()(
persist(
(set, get) => {
const initialPane = makePane()
const initialPane: PaneState = { id: BOOTSTRAP_PANE_ID, tabs: [], activeTabId: null }
return {
panes: [initialPane],
layout: leaf(initialPane.id),
Expand Down