fix(workspace): deterministic bootstrap pane id to stop hydration mismatch#195
Open
rotecodefraktion wants to merge 1 commit into
Open
Conversation
…match makePane() used uuidv4() for the very first pane, so the SSR render and the client's first render produced different editor-tabpanel ids, tripping a React hydration mismatch. Use a fixed BOOTSTRAP_PANE_ID for the pre-rehydration pane; persisted panes (real uuids) replace it client-side after rehydration, so there is no SSR comparison to fail. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
makePane()useduuidv4()for the very first (pre-rehydration) pane,so SSR and the client's first render produced different
editor-tabpanelids, tripping a React hydration mismatch. Thebootstrap pane now uses a fixed
BOOTSTRAP_PANE_ID; persisted panes(real uuids) replace it client-side after rehydration, so there is no
SSR-vs-client id to mismatch.
Why
Eliminates a console hydration warning (and the associated client
re-render) on first load.
How it was tested
npm run lintnpm run typecheck(clean)npm test—workspaceSplits,workspaceNavHistory,workspaceRecents: 31 passnpm run buildNotes
Single-file change (
src/stores/workspaceStore.ts).