ci: migrate to shared workflows#300
Open
mirekys wants to merge 1 commit into
Open
Conversation
* Replaces js-tests with shared inveniosoftware/workflows * Updates Node test matrix to 22.x, 24.x, 26.x * Adds run-js-linter.sh and run-js-tests.sh scripts * Removes conflicting react-app lint rules * Updates Node requirement to >=22.0.0
| for arg in $@; do | ||
| case ${arg} in | ||
| -i|--install) | ||
| npm install;; |
There was a problem hiding this comment.
Shouldn't it run npm ci as before?
Contributor
There was a problem hiding this comment.
I am wondering if we should add both: ci to be used in the GH action, but install locally in case you want to bump dependencies.
| $ESLINT -c .eslintrc.yml src/**/*.js --fix;; | ||
| *) | ||
| printf "Argument ${RED}$arg${NC} not supported\n" | ||
| exit;; |
There was a problem hiding this comment.
I haven't written bash for a while but doesn't this return the status of the last call? Shouldn't it be exit 1;; ?
Author
There was a problem hiding this comment.
Yep it definitely should be! Will fix
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of: inveniosoftware/rfcs#112
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: