Migrate codebase to React 18#298
Open
mirekys wants to merge 5 commits into
Open
Conversation
17 tasks
mirekys
force-pushed
the
mirekys/react-18-migration
branch
from
9f8bd52 to
d55223b
Compare
10 tasks
* Upgrades react and react-dom from ^16.13.0 to ^18.3.0 * Upgrades eslint-config-invenio to ^2.1.0 * Replaces enzyme-adapter-react-16 with @cfaester/enzyme-adapter-react-18 ^0.8.0 * Requires Node version >=22.0.0
mirekys
force-pushed
the
mirekys/react-18-migration
branch
from
d55223b to
9d43498
Compare
10 tasks
* Applies update-react-imports codemod * Applies pure-component codemod * Migrates ReactDOM.render to createRoot API
* Removes unused devDependencies (cheerio, coveralls, expect) * Not used or needed with Node 22+ & React v18 * Fixes npm audit warnings
* Replaces enzyme adapter for React 18 compatibility * Replaces eslint rules to apply React 18 rules
mirekys
force-pushed
the
mirekys/react-18-migration
branch
from
ed3fcdb to
58f618e
Compare
Comment on lines
+113
to
+128
| "overrides": { | ||
| "react-scripts": { | ||
| "svgo": "^3.3.2", | ||
| "resolve-url-loader": "^5.0.0", | ||
| "css-minimizer-webpack-plugin": "^8.0.0" | ||
| }, | ||
| "underscore": "^1.13.8", | ||
| "@tootallnate/once": "^3.0.1", | ||
| "sockjs": "^0.3.24", | ||
| "uuid": "^14.0.0", | ||
| "serialize-javascript": "^7.0.5", | ||
| "workbox-build": "^7.3.0", | ||
| "@svgr/webpack": "^6.5.1", | ||
| "enzyme": { | ||
| "cheerio": "1.0.0-rc.12" | ||
| } |
There was a problem hiding this comment.
Is these overrides needed? Because it's not done in inveniosoftware/react-invenio-forms#334 ?
ntarocco
reviewed
May 13, 2026
Contributor
ntarocco
left a comment
ntarocco
left a comment
There was a problem hiding this comment.
Thanks! I have added a small comment.
| "qs": "^6.8.0", | ||
| "react": "^16.13.0", | ||
| "react-dom": "^16.13.0", | ||
| "react": "^18.3.0", |
Contributor
There was a problem hiding this comment.
Is the min version v18 required now? Can we keep v16 instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Migrate react-searchkit from React 16 to React 18 following RFC inveniosoftware/rfcs#112.
Prerequisites
To make React 18 linting work, you need to link a local clone of eslint-config-invenio:
In this repo:
npm auditdown to just 2 moderate severity vulnerabilities (due towebpack-dev-server- didn't manage to solve that one)Requires:
Part of: inveniosoftware/rfcs#112
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend