Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFVAL_APPEND=trueexisting inConstants.BasicSignerOptions.loadOptions()calledgetAsBool(key)without a default, so missing keys silently resolved tofalseand overrode the field's initial value. Fixed by passingDEFVAL_APPEND/ newDEFVAL_STOREPWDas fallbacks.-aflag always overrides append, andstorePasswordsis not used by the CLI flows.~/.JSignPdfpreferences keep their saved values — both keys are always persisted bystoreOptions(), so only truly fresh installs (or post "Reset Settings") see the new defaults.Test plan
BasicSignerOptionsTest: default field values,loadOptions()with empty props, explicit-false preserved.SigningOptionsViewModelTest: new fresh-VM defaults test; updatedresetToDefaultsexpectation forstorePasswords.mvn -pl jsignpdf test— 110 tests pass.~/.JSignPdf; verify both checkboxes start checked.Docs
website/docs/JSignPdf.adoc— Append signature and Remember passwords sections updated.distribution/doc/release-notes/3.0.0.md— bullet added.