Improve passwords handling when provided from stdin (related to #7)#359
Merged
Improve passwords handling when provided from stdin (related to #7)#359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #357, addressing items surfaced by a post-merge review of the stdin-password feature.
SignerOptionsFromCmdLineused two parallel arrays (String[][] slots+Consumer[] setters) coupled by index; reordering one without the other would have silently assigned a password to the wrong field. Replaced with a singleList<PwdSlot>of records, which also lets the@SuppressWarnings("unchecked")go away.-coming from a properties file must not be reinterpreted as the stdin sentinel, and that a CLI-ksp -with the flag overrides a props-loaded value. Neither path had an assertion. Two integration tests added.-is given without--enable-stdin-passwordswas hardcoded English. Moved to a new resource keyconsole.stdinSentinelWarning(English bundle only — other locales follow via Weblate, perAGENTS.md). Also reworded so the literal value is no longer echoed back at the user.Changes
SignerOptionsFromCmdLine.java— record-based slot list; warning goes throughRES.get(...).messages.properties— newconsole.stdinSentinelWarningkey with{0}= option long name,{1}= flag long name.SignerOptionsFromCmdLineTest.java— two new tests:dashFromPropertiesFile_isNotReinterpretedAsSentinelcliSentinelOverridesPropertiesFileValueTest plan
mvn -pl jsignpdf test -Dtest=StdinPasswordReaderTest,SignerOptionsFromCmdLineTest— 25/25 green (17 inSignerOptionsFromCmdLineTest, including the two new ones; 8 inStdinPasswordReaderTest).