fix: Adjust shell prompt patterns for PreOS environment handling#30
Open
adrianlasota wants to merge 1 commit into
Open
fix: Adjust shell prompt patterns for PreOS environment handling#30adrianlasota wants to merge 1 commit into
adrianlasota wants to merge 1 commit into
Conversation
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
Contributor
|
We don't publish DEVs .whl. |
There was a problem hiding this comment.
Pull request overview
This pull request adjusts Telnet shell prompt detection to better handle PreOS/UEFI environments by changing which prompt regex patterns are used when waiting for a prompt.
Changes:
- Update
_get_shell_prompt_patterns()to omit the generic ANSI-fallback prompt regex when_in_pre_os()isTrue. - Keep the existing dual-pattern behavior (explicit prompt + ANSI fallback) for non-PreOS environments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
coverage: 78.088%. remained the same — telnet_efi into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for determining shell prompt patterns in the
Telnetmodule to better handle the PreOS environment. The main change ensures that when in PreOS, only the explicit prompt pattern is used, avoiding issues with ANSI escape sequences.Prompt pattern handling improvements:
_get_shell_prompt_patternsintelnet.pyto return only the provided prompt pattern (excluding ANSI fallback) when_in_pre_os()isTrue, ensuring correct prompt detection in PreOS environments.