Skip to content

fix: Adjust shell prompt patterns for PreOS environment handling #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrianlasota wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: Adjust shell prompt patterns for PreOS environment handling #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mfd_connect/telnet/telnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ def _in_pre_os(self) -> bool:

def _get_shell_prompt_patterns(self) -> List[bytes]:
"""Return prompt patterns covering both plain and ANSI-colored shell prompts."""
return [self._prompt.encode(), ANSI_SHELL_PROMPT_FALLBACK_REGEX]
# In PreOS environment we don't expect ANSI sequences in prompt, so we return only provided prompt pattern.
Comment thread
adrianlasota marked this conversation as resolved.
return (
[self._prompt.encode(), ANSI_SHELL_PROMPT_FALLBACK_REGEX]
if not self._in_pre_os()
else [self._prompt.encode()]
)
Comment thread
adrianlasota marked this conversation as resolved.

@staticmethod
def _strip_ansi_sequences(text: str) -> str:
Expand Down
Loading