Skip to content

Use logo-derived glyph for menu bar icon#19

Merged
inhaq merged 1 commit into
mainfrom
menubar-logo-glyph
Jun 26, 2026
Merged

Use logo-derived glyph for menu bar icon#19
inhaq merged 1 commit into
mainfrom
menubar-logo-glyph

Conversation

@inhaq

@inhaq inhaq commented Jun 26, 2026

Copy link
Copy Markdown
Owner

This pull request was created by @kiro-agent on behalf of @inhaq 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web


Summary

  • The menu bar icon was a code-drawn SF Symbol (waveform), unrelated to any image asset — so updating the app icons in Resources/ never affected it.
  • Replaces it with a monochrome template glyph that mirrors the app logo (speech-bubble ring + tail + waveform), embedded as a base64 PNG and flagged isTemplate so macOS auto-tints it for light/dark menu bars.
  • Recording/transcribing states keep their distinct status symbols (record.circle / ellipsis.circle).
  • Removes the now-unused StampedMenuBarIcon and the dev-only icon variant.

Notes

  • The glyph was authored as a clean vector-style silhouette (a raw raster trace of the full-color logo collapses into a solid blob) and visually verified at menu bar size on light and dark backgrounds before embedding.
  • This unifies dev and release menu bar icons — the previous dev-only distinct icon is gone. A small dev marker can be re-added if desired.

Testing

  • Not built in CI here (Linux sandbox lacks macOS AppKit/SwiftUI). The embedded base64 decodes to a valid PNG and the Swift is structurally sound; please run a local make build to confirm appearance in the menu bar.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the menu bar icon to render more reliably, with a fallback icon if the custom image can’t be loaded.
    • Improved icon selection so the app now shows the correct menu bar symbol in different states.

Replace the code-drawn SF Symbol menu bar icon with a monochrome template
glyph that mirrors the app logo (speech-bubble ring + tail + waveform).
Embedded as a base64 PNG and flagged as a template image so macOS auto-tints
it for light/dark menu bars. Recording/transcribing states keep their status
symbols. Removes the now-unused StampedMenuBarIcon and the dev-only icon
variant.

Co-authored-by: Inzimam Ul Haq <27832433+inhaq@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 774036ef-56c4-46c4-9765-b1f1c8aabba0

📥 Commits

Reviewing files that changed from the base of the PR and between 57fc005 and 0d3beb9.

📒 Files selected for processing (1)
  • Sources/App.swift

📝 Walkthrough

Walkthrough

MenuBarLabel now renders its icon through a dedicated view builder, and the custom menu bar glyph is built from embedded base64 image data with a system-symbol fallback.

Changes

Menu bar icon refactor

Layer / File(s) Summary
Icon selection
Sources/App.swift
MenuBarLabel now renders the active icon through a @ViewBuilder property and still conditionally shows the checkmark with the same animation values.
BubbleWave image
Sources/App.swift
BubbleWaveMenuBarIcon now creates its template NSImage from an embedded base64 PNG and falls back to waveform.circle if decoding fails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny hopped by the menu bar light,
With a bubble-wave icon looking bright.
If PNG dreams fade,
A symbol is made,
And checkmarks still sparkle just right. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing the menu bar icon with a logo-derived glyph.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch menubar-logo-glyph

Comment @coderabbitai help to get the list of available commands.

@inhaq inhaq merged commit dbc0565 into main Jun 26, 2026
2 checks passed
@inhaq inhaq deleted the menubar-logo-glyph branch June 26, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant