Fix menu bar glyph not showing: draw with NSBezierPath#20
Merged
Conversation
MenuBarExtra does not scale a bitmap NSImage loaded from PNG data, so the base64 image rendered oversized/blank and never appeared. Redraw the same logo-derived glyph (bubble ring + tail + waveform) via a sizing drawing handler, matching the proven template-image approach, so it renders crisp and correctly sized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe menu bar icon image now comes from a drawing handler instead of an embedded base64 PNG. It still uses an 18×18 template image, but the bubble ring, hole, tail, and waveform are rendered with paths. ChangesMenu bar icon rendering
Estimated review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @inhaq 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Follow-up to #19, which merged before the rendering fix landed.
Problem
The glyph added in #19 was embedded as a base64 PNG loaded via
NSImage(data:).MenuBarExtradoes not scale a bitmapNSImage, and SwiftUI's resize modifiers don't apply to it, so the icon rendered oversized/blank and never appeared in the menu bar.Fix
Redraw the same logo-derived glyph (speech-bubble ring + tail + waveform) with
NSBezierPaththrough a sizing drawing handler — the same approach the previous workingStampedMenuBarIconused. This yields a crisp, correctly-sized template image thatMenuBarExtrarenders reliably and macOS auto-tints for light/dark bars. No bitmap, no base64.Testing
make, fully quit the old menu-bar process, and relaunch to confirm the icon appears.Summary by CodeRabbit