refactor(frontend): Button with intent and size replaces the text buttons - #4006
Open
Kadrian wants to merge 4 commits into
Open
refactor(frontend): Button with intent and size replaces the text buttons#4006Kadrian wants to merge 4 commits into
Kadrian wants to merge 4 commits into
Conversation
Kadrian
force-pushed
the
refactor/button-component
branch
from
September 3, 2026 11:56
942d705 to
7c051b8
Compare
awildturtok
approved these changes
Sep 3, 2026
awildturtok
left a comment
Collaborator
There was a problem hiding this comment.
Danke auch für die Tests!
Kadrian
force-pushed
the
refactor/button-component
branch
from
September 3, 2026 16:45
a121f61 to
21bd5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 6: the Button
Stacked on #4005.
ui-components/ButtonreplacesPrimaryButton,TransparentButton,DestroyButtonandSelectFileButton: one component, two axes, fixed heights.IconButtonfollows in the next step.intent:primary(filled),secondary(outlined, the default),tertiary(ghost with hover background),danger(outlined red, fills on hover),link(reads as a text link, no box, no padding; the dropzones' import buttons)size:sm24,md30 (the default, 88 of the app's 119 buttons),lg36 px, each a fixed height with its own text size and icon gap, so text buttons and icon buttons line up; a button whose only children are icons is a square of the same heightaria-pressed, which colors the button; theactiveflag is goneonPress(press events don't bubble, the onestopPropagationwent),isDisabled,autoFocus,excludeFromTabOrderButtonstories: intents, all sizes with text, icon plus text and icon-only, pressed state