refactor(frontend): IconButton folded into Button - #4007
Open
Kadrian wants to merge 3 commits into
Open
Conversation
Kadrian
force-pushed
the
refactor/icon-button-fold
branch
from
September 3, 2026 16:45
60fde8a to
d6b1d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 7: IconButton folded into Button
Stacked on #4006.
IconButtonandBasicButtonare gone; the 93 icon buttons areButtons with anIconchild, so one component covers every button in the app.framebecameintent="secondary", everything elsetertiary;active→aria-pressed,red→text-red,tiny/bare/tight→size="sm",large→lg;bgHover,light,iconColorand the hand-tuned paddings are gone, the fixed sizes own the geometryTooltipTriggergot the tooltip text asaria-label(40 sites); the remaining 20 icon-only buttons without a tooltip still lack an accessible nameonClick→onPress; thestopPropagationcalls went, press events don't bubbleHistoryButton,PreviewButton,QueryResultHistoryButton,DownloadButton) sit onButtonexcludeButtonand the negate action show red when pressed viaaria-pressed:text-red×) aresmNot pretty, but only until the next PR merges: the editor-v2 toolbar and the previous-queries list are
smnow; the download button that waslargeislg.