Skip to content

refactor(frontend): IconButton folded into Button - #4007

Open
Kadrian wants to merge 3 commits into
refactor/button-componentfrom
refactor/icon-button-fold
Open

refactor(frontend): IconButton folded into Button#4007
Kadrian wants to merge 3 commits into
refactor/button-componentfrom
refactor/icon-button-fold

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Design-system prep, step 7: IconButton folded into Button

Stacked on #4006. IconButton and BasicButton are gone; the 93 icon buttons are Buttons with an Icon child, so one component covers every button in the app.

<Button intent="tertiary" aria-label={t("common.delete")} onPress={onDelete}>
  <Icon icon={faTrash} />
</Button>
  • frame became intent="secondary", everything else tertiary; activearia-pressed, redtext-red, tiny/bare/tightsize="sm", largelg; bgHover, light, iconColor and the hand-tuned paddings are gone, the fixed sizes own the geometry
  • icon-only buttons inside a TooltipTrigger got the tooltip text as aria-label (40 sites); the remaining 20 icon-only buttons without a tooltip still lack an accessible name
  • onClickonPress; the stopPropagation calls went, press events don't bubble
  • the select boxes' reset and toggle buttons, the snack message's close button and the wrappers (HistoryButton, PreviewButton, QueryResultHistoryButton, DownloadButton) sit on Button
  • excludeButton and the negate action show red when pressed via aria-pressed:text-red
  • controls line up at 30 px: text, number and date inputs, the search fields and the select boxes have a fixed height (36 px on the login page, like its large button); the small remove and clear buttons (×) are sm

Not pretty, but only until the next PR merges: the editor-v2 toolbar and the previous-queries list are sm now; the download button that was large is lg.

@Kadrian
Kadrian force-pushed the refactor/icon-button-fold branch from 60fde8a to d6b1d15 Compare September 3, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant