Skip to content

refactor(frontend): one Icon component, color inherited, one 14px square frame - #4005

Open
Kadrian wants to merge 1 commit into
refactor/popover-react-ariafrom
refactor/icon-component
Open

refactor(frontend): one Icon component, color inherited, one 14px square frame#4005
Kadrian wants to merge 1 commit into
refactor/popover-react-ariafrom
refactor/icon-component

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Design-system prep, step 5: one Icon in a square frame, color inherited

Stacked on #4002. icon/FaIcon with its twelve flags becomes ui-components/Icon, a thin wrapper over FontAwesomeIcon: explicit icon imports, one component, one frame, color from currentColor.

  • every icon sits centered in a 14 by 14 px frame (size-3.5), so icons line up in rows, lists and menus regardless of glyph shape; the few picture-like icons use a size-* class (the stats block and the preview spinner at 30 px)
  • color is inherited from the surrounding text; a button colors its icon through its own text color, so IconButton's second color table is gone
  • Font Awesome's stylesheet is imported into tailwind's base layer instead of being injected at runtime, so size utilities apply to icons and the w-…! overrides go
  • the color and spacing flags became classes at the 80 call sites; large, small and fixedIconWidth on icons are gone
  • Icon stories: the frame with narrow and wide glyphs, a picture-size icon, color inheritance, spinner

Worth a look: icons that had no flag were hard gray-800 and now follow their text; the fourteen icons that were 16 px are 14 px like all others.

@Kadrian
Kadrian marked this pull request as draft September 3, 2026 10:12
@Kadrian
Kadrian force-pushed the refactor/icon-component branch from 75243b5 to d6b5309 Compare September 3, 2026 10:17
@Kadrian Kadrian changed the title refactor(frontend): one Icon component, colour inherited, one size, fixed width refactor(frontend): one Icon component, color inherited, one size, fixed width Sep 3, 2026
@Kadrian
Kadrian force-pushed the refactor/icon-component branch 2 times, most recently from 4ea1727 to 0546b31 Compare September 3, 2026 10:53
@Kadrian Kadrian changed the title refactor(frontend): one Icon component, color inherited, one size, fixed width refactor(frontend): one Icon component, color inherited, one 14px square frame Sep 3, 2026
@Kadrian
Kadrian force-pushed the refactor/icon-component branch 6 times, most recently from ae78f5e to 70f8f91 Compare September 3, 2026 11:09
@Kadrian
Kadrian marked this pull request as ready for review September 3, 2026 11:11
@Kadrian
Kadrian force-pushed the refactor/icon-component branch from 70f8f91 to 30b74e3 Compare September 3, 2026 16:45
@Kadrian
Kadrian marked this pull request as draft September 3, 2026 20:43
@Kadrian
Kadrian marked this pull request as ready for review September 3, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants