refactor(frontend): one Icon component, color inherited, one 14px square frame - #4005
Open
Kadrian wants to merge 1 commit into
Open
refactor(frontend): one Icon component, color inherited, one 14px square frame#4005Kadrian wants to merge 1 commit into
Kadrian wants to merge 1 commit into
Conversation
Kadrian
marked this pull request as draft
September 3, 2026 10:12
Kadrian
force-pushed
the
refactor/icon-component
branch
from
September 3, 2026 10:17
75243b5 to
d6b5309
Compare
Kadrian
force-pushed
the
refactor/icon-component
branch
2 times, most recently
from
September 3, 2026 10:53
4ea1727 to
0546b31
Compare
Kadrian
force-pushed
the
refactor/icon-component
branch
6 times, most recently
from
September 3, 2026 11:09
ae78f5e to
70f8f91
Compare
Kadrian
marked this pull request as ready for review
September 3, 2026 11:11
awildturtok
approved these changes
Sep 3, 2026
Kadrian
force-pushed
the
refactor/icon-component
branch
from
September 3, 2026 16:45
70f8f91 to
30b74e3
Compare
Kadrian
marked this pull request as draft
September 3, 2026 20:43
Kadrian
marked this pull request as ready for review
September 3, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 5: one Icon in a square frame, color inherited
Stacked on #4002.
icon/FaIconwith its twelve flags becomesui-components/Icon, a thin wrapper overFontAwesomeIcon: explicit icon imports, one component, one frame, color fromcurrentColor.size-3.5), so icons line up in rows, lists and menus regardless of glyph shape; the few picture-like icons use asize-*class (the stats block and the preview spinner at 30 px)IconButton's second color table is gonew-…!overrides golarge,smallandfixedIconWidthon icons are goneIconstories: the frame with narrow and wide glyphs, a picture-size icon, color inheritance, spinnerWorth a look: icons that had no flag were hard gray-800 and now follow their text; the fourteen icons that were 16 px are 14 px like all others.