refactor(frontend): buttons on react-aria Button - #4003
Open
Kadrian wants to merge 2 commits into
Open
Conversation
Kadrian
force-pushed
the
refactor/button-react-aria
branch
2 times, most recently
from
September 3, 2026 09:16
f69bf57 to
d4afee4
Compare
Kadrian
force-pushed
the
refactor/button-react-aria
branch
2 times, most recently
from
September 3, 2026 09:48
da32f27 to
b224fe2
Compare
awildturtok
approved these changes
Sep 3, 2026
Kadrian
force-pushed
the
refactor/button-react-aria
branch
from
September 3, 2026 16:45
1c19300 to
e925f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 3: buttons on react-aria's Button
Stacked on #4000.
BasicButtonrenders react-aria-components'Button, so every button built on it is the trigger thatTooltipTrigger,MenuTriggerand friends expect, with no wrappers or hook wiring of our own.disabledmaps toisDisabled,onClickis react-aria's alias foronPressand keeps its mouse eventtitledropped at five buttons that had a label or tooltip anyway,tabIndex={-1}→excludeFromTabOrderat three,aria-hidden→aria-labelat onestopPropagationcalls are redundant now but harmlessdata-hovered,data-pressed,data-focus-visibleandisPendingbecome available for the Button rework.