Skip to content

refactor(frontend): buttons on react-aria Button - #4003

Open
Kadrian wants to merge 2 commits into
refactor/tooltip-react-ariafrom
refactor/button-react-aria
Open

refactor(frontend): buttons on react-aria Button#4003
Kadrian wants to merge 2 commits into
refactor/tooltip-react-ariafrom
refactor/button-react-aria

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Design-system prep, step 3: buttons on react-aria's Button

Stacked on #4000. BasicButton renders react-aria-components' Button, so every button built on it is the trigger that TooltipTrigger, MenuTrigger and friends expect, with no wrappers or hook wiring of our own.

  • call sites unchanged: disabled maps to isDisabled, onClick is react-aria's alias for onPress and keeps its mouse event
  • react-aria's Button forwards only the DOM attributes it knows: title dropped at five buttons that had a label or tooltip anyway, tabIndex={-1}excludeFromTabOrder at three, aria-hiddenaria-label at one
  • press semantics on all buttons: click events stop at the button, focus on press, no text selection while pressing. The explicit stopPropagation calls are redundant now but harmless

data-hovered, data-pressed, data-focus-visible and isPending become available for the Button rework.

@Kadrian
Kadrian force-pushed the refactor/button-react-aria branch 2 times, most recently from f69bf57 to d4afee4 Compare September 3, 2026 09:16
@Kadrian
Kadrian force-pushed the refactor/button-react-aria branch 2 times, most recently from da32f27 to b224fe2 Compare September 3, 2026 09:48
@Kadrian
Kadrian force-pushed the refactor/button-react-aria branch from 1c19300 to e925f9c Compare September 3, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants