Skip to content

refactor(frontend): menus on react-aria-components, drop tippy - #4002

Open
Kadrian wants to merge 8 commits into
refactor/button-react-ariafrom
refactor/popover-react-aria
Open

refactor(frontend): menus on react-aria-components, drop tippy#4002
Kadrian wants to merge 8 commits into
refactor/button-react-ariafrom
refactor/popover-react-aria

Conversation

@Kadrian

@Kadrian Kadrian commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Design-system prep, step 4: menus on react-aria-components, tippy removed

Stacked on #4003. The three click overlays, help menu, download list and the delete/reset confirmations, are menus: a list of actions or links to pick from. They move to react-aria's MenuTrigger with our Menu, and tippy goes.

<MenuTrigger>
  <IconButton  />
  <Menu aria-label="…" onAction={(key) => }>
    <MenuItem id="…"></MenuItem>
    <MenuItem href="…"></MenuItem>
  </Menu>
</MenuTrigger>
  • ui-components/Menu: Menu brings its own popover, so all menus share one offset and overflow behaviour and placement is the only knob; MenuItem with danger; items focus on hover, arrow keys move, Enter picks, Escape closes and returns focus
  • ConfirmableTooltipConfirmMenu, a one-item menu that closes itself after the action
  • help menu and download list are link items; menus open below the trigger and flip when there is no room
  • tippy packages and CSS overrides removed; the e2e test follows the confirmation into its portal
  • Menu stories

@Kadrian
Kadrian marked this pull request as draft September 2, 2026 20:04
@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch 6 times, most recently from b5d0146 to de2e0e2 Compare September 3, 2026 09:00
@Kadrian
Kadrian marked this pull request as ready for review September 3, 2026 09:00
@Kadrian
Kadrian changed the base branch from refactor/tooltip-react-aria to refactor/button-react-aria September 3, 2026 09:01
@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch from 5052348 to 006e1fe Compare September 3, 2026 09:16
@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch 2 times, most recently from 938ecb4 to 66eff5b Compare September 3, 2026 09:17
@Kadrian Kadrian changed the title refactor(frontend): popovers on react-aria-components, drop tippy refactor(frontend): menus on react-aria-components, drop tippy Sep 3, 2026
@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch from 2330dae to 3cbfbdb Compare September 3, 2026 09:48
@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch from e99bbc7 to c9aa97a Compare September 3, 2026 10:24
{resultUrls.map((resultUrl) => {
const { icon, color } = getFileIcon(resultUrl.url);

return (

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das sieht mir nach einer kleinen Änderung aus, hast du geschaut, dass es am Ende nah genug am alten dran ist?

@Kadrian
Kadrian force-pushed the refactor/popover-react-aria branch from c9aa97a to 456391a Compare September 3, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants