refactor(frontend): menus on react-aria-components, drop tippy - #4002
Open
Kadrian wants to merge 8 commits into
Open
refactor(frontend): menus on react-aria-components, drop tippy#4002Kadrian wants to merge 8 commits into
Kadrian wants to merge 8 commits into
Conversation
Kadrian
marked this pull request as draft
September 2, 2026 20:04
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
6 times, most recently
from
September 3, 2026 09:00
b5d0146 to
de2e0e2
Compare
Kadrian
marked this pull request as ready for review
September 3, 2026 09:00
Kadrian
changed the base branch from
refactor/tooltip-react-aria
to
refactor/button-react-aria
September 3, 2026 09:01
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
from
September 3, 2026 09:16
5052348 to
006e1fe
Compare
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
2 times, most recently
from
September 3, 2026 09:17
938ecb4 to
66eff5b
Compare
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
from
September 3, 2026 09:48
2330dae to
3cbfbdb
Compare
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
from
September 3, 2026 10:24
e99bbc7 to
c9aa97a
Compare
awildturtok
approved these changes
Sep 3, 2026
| {resultUrls.map((resultUrl) => { | ||
| const { icon, color } = getFileIcon(resultUrl.url); | ||
|
|
||
| return ( |
Collaborator
There was a problem hiding this comment.
Das sieht mir nach einer kleinen Änderung aus, hast du geschaut, dass es am Ende nah genug am alten dran ist?
Kadrian
force-pushed
the
refactor/popover-react-aria
branch
from
September 3, 2026 16:45
c9aa97a to
456391a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 4: menus on react-aria-components, tippy removed
Stacked on #4003. The three click overlays, help menu, download list and the delete/reset confirmations, are menus: a list of actions or links to pick from. They move to react-aria's
MenuTriggerwith ourMenu, and tippy goes.ui-components/Menu:Menubrings its own popover, so all menus share one offset and overflow behaviour andplacementis the only knob;MenuItemwithdanger; items focus on hover, arrow keys move, Enter picks, Escape closes and returns focusConfirmableTooltip→ConfirmMenu, a one-item menu that closes itself after the actionMenustories