refactor(frontend): hover tooltips on react-aria-components - #4000
Draft
Kadrian wants to merge 1 commit into
Draft
refactor(frontend): hover tooltips on react-aria-components#4000Kadrian wants to merge 1 commit into
Kadrian wants to merge 1 commit into
Conversation
Kadrian
marked this pull request as draft
September 2, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-system prep, step 2: hover tooltips on react-aria-components
Stacked on #3999.
WithTooltip(tippy) is replaced byui-components/Tooltipbuilt on react-aria-components, using its composition shape so the call sites don't change again when more components move to react-aria:Main change
react-aria-componentsandreact-ariaadded; tippy stays only for the three click popovers (HelpMenu,DownloadResultsDropdownButton,ConfirmableTooltip), which move to aPopoverin the next stepBasicButtonreads the trigger props throughuseFocusable, so every existing button is a tooltip trigger on its own, without wrappers, and stays one when it becomes a react-ariaButtonTooltipTargetmarks non-button content (icons, node labels, dropzones) as the trigger; static content keepsexcludeFromTabOrderso the tab order is unchanged, help icons become keyboard reachableTooltiprenders nothing without content, so optional texts work as before;wideandplacementkept,lazybecamedelay={1500}--animate-fade-in/out)index.css, firstTooltipstoriesWorth a closer look
classNameon the oldWithTooltipstyled tippy's box, not the trigger, so those classes were dropped; thewhitespace-nowrapone moved onto theTooltipNext steps
Popoverfor the three click uses, remove tippyButtonandIconconsolidation inui-components