This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Repository navigation
Conversation
Off Linux the compositor is a stub whose socket name is empty, but every
PTY CREATE still passed Some("") to session_env, which exported an empty
WAYLAND_DISPLAY and pinned Qt, GTK, SDL, Electron and Firefox to Wayland.
On macOS a Qt app then aborts: "Could not find the Qt platform plugin
wayland ... Available platform plugins are: cocoa".
|
No issues found.
All CI checks now pass on
Select any unchecked box below to run or rerun that agent. Passed (1)
Full resultsIndent Review Agent
|
Coverage
|
![indent[bot]](https://avatars.githubusercontent.com/in/4161513?s=60&v=4){kind=small}
|
Closing: neo is moving off blit to yas entirely (ENG-4014). The same fix goes to yas. |
indent
Bot
deleted the
jsegaran/eng-4014-no-wayland-env-without-compositor
branch
October 26, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-4014.
On non-Linux,
blit_compositor::spawn_compositoris a stub withsocket_name: String::new(), but PTY CREATE/RESTART andPROCESS_SPAWN_SESSION_ENVstill passSome("")toapp_env::session_env. Since e3c4ca8 (v0.50.0) that exportsWAYLAND_DISPLAY=plus everytoolkit_envpin (QT_QPA_PLATFORM=wayland,GDK_BACKEND=wayland,SDL_VIDEODRIVER=wayland,XDG_SESSION_TYPE=wayland, ...) into every macOS shell. Qt apps there then abort with "Could not find the Qt platform plugin "wayland" ... Available platform plugins are: cocoa" (seen with the Android emulator from the Indent desktop app).session_envnow treats an empty socket name as no display. Linux is unchanged: a real compositor always has a non-empty socket path.Testing: new
an_empty_socket_name_sets_no_display_variablesunit test; it fails without the fix and passes with it.cargo test -p blit-server --lib app_env,cargo fmt -- --checkandcargo clippy -p blit-server --all-targets -- -D warnings(Rust 1.97.1) pass.Rollout: needs a blit release, then a
@blit-sh/*bump in neo and a desktop app build.yas-run/yashas the sameif let Some(wd) = wayland_displayincrates/server/src/app_env.rsand the same empty-name stub, so the one-line change applies there too.Tag
@indentto continue the conversation here.