Repository navigation
Conversation
Off Linux the compositor is a stub whose socket name is empty, but PTY and
session-env spawns still passed Some("") to session_env, which exported an
empty WAYLAND_DISPLAY and pinned Qt, GTK, SDL, Electron and Firefox to
Wayland. On macOS a Qt app then aborts: "Could not find the Qt platform
plugin wayland ... Available platform plugins are: cocoa".
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the yas half of ENG-4014.
Off Linux,
spawn_compositoris a stub whosesocket_nameis empty, but PTY spawns andprepare_session_envstill passSome("")toapp_env::session_env. That exportsWAYLAND_DISPLAY=plus everytoolkit_envpin (QT_QPA_PLATFORM=wayland,GDK_BACKEND=wayland,SDL_VIDEODRIVER=wayland,XDG_SESSION_TYPE=wayland, ...) into every macOS shell, and Qt apps abort with "Could not find the Qt platform plugin "wayland" ... Available platform plugins are: cocoa".session_envnow treats an empty socket name as no display. Linux is unchanged: a real compositor always has a non-empty socket path.yas-run/yasmain (117716c) has the identical code, so this applies upstream as is.Testing: new
an_empty_socket_name_sets_no_display_variablestest.cargo test -p yas-server --lib app_env,cargo fmt -- --checkandcargo clippy -p yas-server --all-targets -- -D warnings(Rust 1.97.1) pass. The same change and test failed without the fix in blit (indent-com/blit#319, closed in favor of this).Tag
@indentto continue the conversation here.