Skip to content

security: structured logging + opaque error IDs (stop leaking str(e) in 500s) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imran31415 merged 1 commit into from
Jun 16, 2026
Merged

security: structured logging + opaque error IDs (stop leaking str(e) in 500s) #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions charts/workspace/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5680,6 +5680,8 @@ def do_POST(self):
self.send_response(404)
self.end_headers()
self.wfile.write(f'API endpoint not found. Received: {self.path}'.encode())
except ValueError as e:
self.send_client_error(str(e), 400)
except Exception as e:
self.send_error_response(f'Server error: {str(e)}')

Expand All @@ -5690,10 +5692,21 @@ def send_success_response(self, message):
self.wfile.write(message.encode())

def send_error_response(self, message):
error_id = uuid.uuid4().hex[:12]
import traceback
traceback.print_exc()
print(f'[error_id={error_id}] {message}', file=sys.stderr)
body = json.dumps({'error': 'internal error', 'error_id': error_id})
self.send_response(500)
self.send_header('Content-type', 'text/plain')
self.send_header('Content-type', 'application/json')
self.end_headers()
self.wfile.write(message.encode())
self.wfile.write(body.encode())
def send_client_error(self, message, status_code=400):
body = json.dumps({'error': message})
self.send_response(status_code)
self.send_header('Content-type', 'application/json')
self.end_headers()
self.wfile.write(body.encode())

def send_livez(self):
"""Liveness probe — proves the HTTP server thread is alive and can
Expand Down