updated GHAction#100
Conversation
|
@alcooper91 @m-alkalbani pointed fix (replacing with |
|
SGTM |
|
Is your comment the error that's being reported by the build script? I see it saying failed but I'm not seeing the error. |
lines are error generated by bikeshed, which runs under GHAction (w3c/spec-prod), and procedure (and GHAction) will fail when subroutines report error. That's why you will see "checks have failed" message at merge PR panel in this page. |
|
I think it's reasonable to do that. Do you have a pointer to the bikeshed errors? Or is that the fix you were proposing? Either way is good with me. |
|
I'm not sure you can view action log (no personal knowledge on permissions aroUnd these logs...), it's at view details for build and deploy check (menu will be shown with horiz bullets right hand of line, if github shows to you) (re-checked carefully, and found that this was not from bikeshed.itself, but webidl validator, sorry..) |
close #99
for immersive-web/administrivia#242