Skip to content

updated GHAction#100

Merged
himorin merged 3 commits into
mainfrom
himorin/administrivia-242
May 8, 2026
Merged

updated GHAction#100
himorin merged 3 commits into
mainfrom
himorin/administrivia-242

Conversation

@himorin

@himorin himorin commented May 1, 2026

Copy link
Copy Markdown
Member

@himorin

himorin commented May 1, 2026

Copy link
Copy Markdown
Member Author

@alcooper91 @m-alkalbani pointed fix (replacing with Exposed=Window) works for you two? (this sync with Core API definition, and should be correct)

  Invalid Web IDL detected:
    Validation error at line 5, inside `interface XRTest`:
    interface XRTest {
              ^ Interfaces must have `[Exposed]` extended attribute. To fix, add, for example, `[Exposed=Window]`. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the [WebIDL spec section on Exposed](https://heycam.github.io/webidl/#Exposed) for more information.
    
    Validation error at line 68, inside `interface FakeXRDevice`:
    interface FakeXRDevice : EventTarget {
              ^ Interfaces must have `[Exposed]` extended attribute. To fix, add, for example, `[Exposed=Window]`. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the [WebIDL spec section on Exposed](https://heycam.github.io/webidl/#Exposed) for more information.
    
    Validation error at line 104, inside `interface FakeXRInputController`:
    interface FakeXRInputController {
              ^ Interfaces must have `[Exposed]` extended attribute. To fix, add, for example, `[Exposed=Window]`. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the [WebIDL spec section on Exposed](https://heycam.github.io/webidl/#Exposed) for more information.
    
    Validation error at line 190, inside `interface FakeXRAnchorController`:
    interface FakeXRAnchorController {
              ^ Interfaces must have `[Exposed]` extended attribute. To fix, add, for example, `[Exposed=Window]`. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the [WebIDL spec section on Exposed](https://heycam.github.io/webidl/#Exposed) for more information.
    
  ❌  Invalid Web IDL detected... please fix the issues above.

@alcooper91

Copy link
Copy Markdown
Contributor

SGTM

@alcooper91

Copy link
Copy Markdown
Contributor

Is your comment the error that's being reported by the build script? I see it saying failed but I'm not seeing the error.

@himorin

himorin commented May 7, 2026

Copy link
Copy Markdown
Member Author

Is your comment the error that's being reported by the build script? I see it saying failed but I'm not seeing the error.

lines are error generated by bikeshed, which runs under GHAction (w3c/spec-prod), and procedure (and GHAction) will fail when subroutines report error. That's why you will see "checks have failed" message at merge PR panel in this page.
We could merge this PR now, but gh-pages will not be updated before fixing errors.

@alcooper91

Copy link
Copy Markdown
Contributor

I think it's reasonable to do that. Do you have a pointer to the bikeshed errors? Or is that the fix you were proposing? Either way is good with me.

@himorin

himorin commented May 8, 2026

Copy link
Copy Markdown
Member Author

I'm not sure you can view action log (no personal knowledge on permissions aroUnd these logs...), it's at view details for build and deploy check (menu will be shown with horiz bullets right hand of line, if github shows to you)
all related lig lines are copied into my comment.
let me open another PR for this shortly. (not to include here, to prevent messy changelog)

(re-checked carefully, and found that this was not from bikeshed.itself, but webidl validator, sorry..)

@himorin himorin merged commit f0c91a6 into main May 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy is broken

2 participants