Skip to content

added [Exposed=Window] to Interface defs#102

Merged
himorin merged 2 commits into
mainfrom
himorin/202605-webidlvalidation
May 8, 2026
Merged

added [Exposed=Window] to Interface defs#102
himorin merged 2 commits into
mainfrom
himorin/202605-webidlvalidation

Conversation

@himorin

@himorin himorin commented May 8, 2026

Copy link
Copy Markdown
Member

for ghaction webidl validation error, at #100

  • may need [SecureContext, Exposed=Window] but not only [Exposed=Window]?

Preview | Diff

@himorin himorin requested a review from alcooper91 May 8, 2026 04:13

@alcooper91 alcooper91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine either way. All of the spec constructs are [SecureContext], so I don't think that'll break anything.

@himorin

himorin commented May 8, 2026

Copy link
Copy Markdown
Member Author

@alcooper91 thx for comment, updated with adding SecureContext

@alcooper91

Copy link
Copy Markdown
Contributor

Still LGTM

@himorin himorin merged commit b84e527 into main May 8, 2026
github-actions Bot added a commit that referenced this pull request May 8, 2026
…ation

SHA: b84e527
Reason: push, by himorin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@himorin

himorin commented May 8, 2026

Copy link
Copy Markdown
Member Author

published to github.io
https://immersive-web.github.io/webxr-test-api/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants