Skip to content

chore: update and modernize GitHub Actions workflows - #462

Merged
ikkentim merged 6 commits into
masterfrom
copilot/update-modernize-workflow-actions
Apr 30, 2026
Merged

chore: update and modernize GitHub Actions workflows#462
ikkentim merged 6 commits into
masterfrom
copilot/update-modernize-workflow-actions

Conversation

Copilot AI commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Replace deprecated release actions (create-release@v1, upload-release-asset@v1) with softprops/action-gh-release@v2
  • Add if-no-files-found: error to all upload-artifact steps
  • Update actions/checkout from v4 → v6
  • Update actions/upload-artifact from v4 → v7
  • Update actions/download-artifact from v4 → v8
  • Update actions/setup-dotnet from v4 → v5
  • Resolve merge conflicts with master (added Directory.Packages.props to solution files)

Copilot AI and others added 4 commits April 30, 2026 15:48
Copilot AI requested a review from ikkentim April 30, 2026 16:59
Base automatically changed from copilot/migrate-to-slnx-cleanup-solutions to master April 30, 2026 17:54
ikkentim
ikkentim requested changes Apr 30, 2026
View reviewed changes

@ikkentim ikkentim left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions, such as actions/upload-artifact are on an older version, should we not update?

Copilot AI commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

actions, such as actions/upload-artifact are on an older version, should we not update?

The actions like checkout, upload-artifact, download-artifact, and setup-dotnet are already on @v4, which is the latest major version for each of them. The only outdated actions were actions/create-release@v1 and actions/upload-release-asset@v1 (both officially deprecated), which were replaced by softprops/action-gh-release@v2 in this PR.

Copilot AI requested a review from ikkentim April 30, 2026 18:01
@ikkentim

ikkentim commented Apr 30, 2026

Copy link
Copy Markdown
Owner

actions, such as actions/upload-artifact are on an older version, should we not update?

The actions like checkout, upload-artifact, download-artifact, and setup-dotnet are already on @v4, which is the latest major version for each of them. The only outdated actions were actions/create-release@v1 and actions/upload-release-asset@v1 (both officially deprecated),

actions, such as actions/upload-artifact are on an older version, should we not update?

The actions like checkout, upload-artifact, download-artifact, and setup-dotnet are already on @v4, which is the latest major version for each of them. The only outdated actions were actions/create-release@v1 and actions/upload-release-asset@v1 (both officially deprecated), which were replaced by softprops/action-gh-release@v2 in this PR.

@copilot https://github.com/actions/upload-artifact states @7 is latest.

Copilot AI commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

actions, such as actions/upload-artifact are on an older version, should we not update?

The actions like checkout, upload-artifact, download-artifact, and setup-dotnet are already o...

Updated all actions to their latest major versions in commit 1259f1f:

  • actions/checkout@v4 → @v6
  • actions/upload-artifact@v4 → @v7
  • actions/download-artifact@v4 → @v8
  • actions/setup-dotnet@v4 → @v5

@ikkentim

ikkentim commented Apr 30, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

@ikkentim
Merge remote-tracking branch 'origin/master' into copilot/update-mode…
8be4e8f 
…rnize-workflow-actions

# Conflicts:
#	SampSharp.slnx
#	src/legacy/SampSharp.Legacy.slnx

Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot AI commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit 8be4e8f. The conflicts were in SampSharp.slnx and src/legacy/SampSharp.Legacy.slnx — both files simply needed to include the Directory.Packages.props entry that was added to master in #459.

@ikkentim
ikkentim marked this pull request as ready for review April 30, 2026 18:28
@ikkentim
ikkentim merged commit e56473d into master Apr 30, 2026
6 checks passed
@ikkentim
ikkentim deleted the copilot/update-modernize-workflow-actions branch April 30, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikkentim ikkentim Awaiting requested review from ikkentim

Assignees

@ikkentim ikkentim

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ikkentim