Fix Scenario errors in add_year()#986
Open
glatterf42 wants to merge 2 commits into
Open
Conversation
Member
Author
|
Ideally, this PR would add a test that confirms that the fix here actually does what we intend it to do. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #578.
In that issue, @gidden mentioned that this branch by Behnam contained a fix for the issue. However, that branch has become severely outdated over the years. So after rebasing #494, I created a new branch here that captures the changes contained in @behnam-zakeri's branch.
I'm not sure what's still missing in #494, but I think this could be a good opportunity to move things along. And the assessments in #578 made me think that things need to move along to address these known bugs.
How to review
PR checklist