Skip to content

Adjust for pandas-stubs 2.3.3.251201#992

Merged
khaeru merged 2 commits into
mainfrom
ci/pandas-stubs-2.3.3.251201
Dec 2, 2025
Merged

Adjust for pandas-stubs 2.3.3.251201#992
khaeru merged 2 commits into
mainfrom
ci/pandas-stubs-2.3.3.251201

Conversation

@khaeru
Copy link
Copy Markdown
Member

@khaeru khaeru commented Dec 2, 2025

Pandas-stubs v2.3.3.251201 was released (per the version) on 2025-12-01. This led to mypy errors in the "Code quality" job of the "pytest" CI workflow.

The PR adjusts:

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, type hinting only
  • Update release notes. ditto

@khaeru khaeru added this to the 3.12 milestone Dec 2, 2025
@khaeru khaeru added enh New features & functionality ci Continuous integration labels Dec 2, 2025
@khaeru khaeru self-assigned this Dec 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.2%. Comparing base (26aebd4) to head (0ce4246).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
message_ix/tools/add_year/__init__.py 0.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #992   +/-   ##
=====================================
  Coverage   92.2%   92.2%           
=====================================
  Files         60      60           
  Lines       5155    5155           
=====================================
  Hits        4756    4756           
  Misses       399     399           
Files with missing lines Coverage Δ
message_ix/core.py 93.4% <ø> (ø)
message_ix/tools/add_year/__init__.py 66.7% <0.0%> (ø)

@khaeru
Copy link
Copy Markdown
Member Author

khaeru commented Dec 2, 2025

The CI checks are visible on this run triggered by the "labeled" event, rather than the "pull_request_target" event. All pass.

We accept the codecov/patch check failure because, as noted:

These lines of code [in add_year/__init__.py] are not covered by tests

@khaeru khaeru merged commit ae12261 into main Dec 2, 2025
32 of 56 checks passed
@khaeru khaeru deleted the ci/pandas-stubs-2.3.3.251201 branch December 2, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration enh New features & functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant