Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ All notable changes to `@ichava/js-icon-components` follow [Keep a Changelog](ht

### Changed

- **The openmoji pack is pinned at `25280ae1`** (ichava/icon-sets-openmoji#7 and #8), up from `d492519e`: 8,568 SVGs, generated as 8,566. Its `attribution` names `resources/assets/svg/licenses/openmoji/LICENSE.txt`, the upstream licence that replaced the hand-placed `LICENSE` in #8, so `dist/<flavour>/openmoji/` now carries `LICENSE.txt`. The high-speed-train `exclude` is gone (fixed upstream in #4, and the build fails on an entry that passes). Two new entries exclude the `uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg` flag in both sets, which keeps an unused `xmlns:sodipodi` declaration the gate rejects.
- **The flag pack is pinned at `2d7b51ce`** (ichava/icon-sets-flag#94), up from `67075d3f`, so the generated US and UM flags carry their stars: the four `us`/`um` icons now hold the `<marker>` and its `marker-mid` reference, which the sanitiser accepts since ichava/js-icon-components#9. Still 542 icons. `docs/packs.md` names the commit.
- **Each per-pack release tarball is its own package**, `@ichava/js-icon-components-<pack>`, with the same subpath exports; the full tarball keeps `@ichava/js-icon-components`. They used to share the full package's name, so npm kept only one: installing a second replaced the first. Imports from a per-pack tarball now name it (`@ichava/js-icon-components-tabler/react/tabler`). The tarball checker refuses a per-pack tarball with the shared name.
- The full release tarball is 49.6 MB to download and 249.4 MB unpacked (was 7.0 MB and 64.2 MB), almost all of it the asset exports, and installs offline in about 12 s. Per-pack tarballs are 7.6 to 23.5 MB (measured 2026-11-04, after the PNG and Android VectorDrawable exports were dropped; with both the full tarball was 133.4 MB and 358 MB, and with the Android export alone 62.3 MB and 266.1 MB). A git build that lists only its flavours writes no export.
- `manifest.json` gains `assets`, `unbuilt.assets` and, per pack, `assets` and `variants`.
Expand Down
17 changes: 10 additions & 7 deletions docs/packs.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,21 @@ Four packs are generated, each read from git at a pinned commit and each keeping
| Pack | Repository | Commit | Sets (default first) | Icons | Artwork licence |
|---|---|---|---|---:|---|
| `tabler` | `ichava/icon-sets-tabler` | `10a5f39c` | `outline`, `filled` | 6,257 | MIT |
| `flag` | `ichava/icon-sets-flag` | `67075d3f` | `4x3`, `1x1` | 542 | MIT |
| `flag` | `ichava/icon-sets-flag` | `2d7b51ce` | `4x3`, `1x1` | 542 | MIT |
| `emoji` | `ichava/icon-sets-emoji` | `833f11fb` | `twemoji` | 3,435 | CC-BY-4.0 |
| `openmoji` | `ichava/icon-sets-openmoji` | `d492519e` | `openmoji-color`, `openmoji-black` | 7,131 | CC-BY-SA-4.0 |
| `openmoji` | `ichava/icon-sets-openmoji` | `25280ae1` | `openmoji-color`, `openmoji-black` | 8,566 | CC-BY-SA-4.0 |

Counts are measured at those commits on 2026-11-04. `packs.json` holds the full SHAs.
Counts are measured at those commits on 2026-11-04 (flag and openmoji on 2026-11-05). `packs.json` holds the full SHAs.

- **`emoji` is Twemoji only.** `icon-sets-emoji` also carries the two OpenMoji sets, but deprecates
them there in favour of `icon-sets-openmoji`. Generating them twice would ship 7,132 icons twice.
- **`openmoji` leaves out one icon.** `openmoji-color/travel-places/high-speed-train.svg` has a stray
text node, which the SVG gate rejects. It is listed under `exclude` in `packs.json` with that
reason, and the build fails if the entry stops being rejected, so the fix upstream brings the
icon back.
- **`openmoji` leaves out two icons.** The `uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg`
flag in both sets keeps an unused `xmlns:sodipodi` declaration on `<svg>`, which the SVG gate
rejects. Both are listed under `exclude` in `packs.json` with that reason, and the build fails if
an entry stops being rejected, so the fix upstream brings them back. The high-speed train excluded
before is fixed upstream (icon-sets-openmoji#4) and generated again.
- **`openmoji` includes `uncategorised/`**, the OpenMoji extras the Unicode taxonomy does not name,
511 per set at `25280ae1`, under their upstream file names.
- **Not generated:** `icon-sets-bundled` is private and licensed for Simtabi's internal and client
use only, so a public package cannot ship it; `icon-sets-metronic` is private and never shown
publicly.
Expand Down
14 changes: 9 additions & 5 deletions packs.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{
"id": "flag",
"repository": "https://github.com/ichava/icon-sets-flag.git",
"ref": "67075d3f8d41e9d95635200e91ba8f8135feeb34",
"ref": "2d7b51ce0edfa1854c43a36e2a6ede6ff4782052",
"checkout": "../icon-sets-flag",
"path": "resources/assets/svg/files",
"sets": ["4x3", "1x1"],
Expand Down Expand Up @@ -45,7 +45,7 @@
{
"id": "openmoji",
"repository": "https://github.com/ichava/icon-sets-openmoji.git",
"ref": "d492519e061732592a7d7c57bd6531747f10694c",
"ref": "25280ae1f030f748ed6613d42a24569fcb1bd18f",
"checkout": "../icon-sets-openmoji",
"path": "resources/assets/svg/files",
"sets": ["openmoji-color", "openmoji-black"],
Expand All @@ -54,11 +54,15 @@
"kind": "icon",
"minIcons": 7000,
"licence": "CC-BY-SA-4.0",
"attribution": ["ATTRIBUTION.md", "resources/assets/svg/licenses/openmoji/LICENSE"],
"attribution": ["ATTRIBUTION.md", "resources/assets/svg/licenses/openmoji/LICENSE.txt"],
"exclude": [
{
"path": "openmoji-color/travel-places/high-speed-train.svg",
"reason": "A stray text node (\"d\") inside <g id=\"color\">, outside any text element, at d492519e. The policy rejects rather than strips; the fix belongs upstream in icon-sets-openmoji. Measured 2026-11-04: the only one of 7,132."
"path": "openmoji-color/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg",
"reason": "An unused xmlns:sodipodi declaration on <svg>, left by Inkscape, at 25280ae1. icon-sets-sync's sanitiser strips sodipodi:docname but keeps namespace declarations, and this policy rejects any attribute not on the allow-list. The fix belongs in icon-sets-sync (drop unused namespace declarations) or upstream. Measured 2026-11-05: the only 2 of 8,568."
},
{
"path": "openmoji-black/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg",
"reason": "An unused xmlns:sodipodi declaration on <svg>, left by Inkscape, at 25280ae1. icon-sets-sync's sanitiser strips sodipodi:docname but keeps namespace declarations, and this policy rejects any attribute not on the allow-list. The fix belongs in icon-sets-sync (drop unused namespace declarations) or upstream. Measured 2026-11-05: the only 2 of 8,568."
}
]
}
Expand Down
7 changes: 5 additions & 2 deletions tests/generate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function inputCount(pack: PackConfig): number {
}

/** Measured 2026-11-04 at the pinned refs. A ref bump that changes a count updates this table. */
const MEASURED: Record<string, number> = { tabler: 6257, flag: 542, emoji: 3435, openmoji: 7132 };
const MEASURED: Record<string, number> = { tabler: 6257, flag: 542, emoji: 3435, openmoji: 8568 };

const PACKS = packs();
const rows = PACKS.map((p) => [p.id, p] as const);
Expand Down Expand Up @@ -81,7 +81,10 @@ describe('generation', () => {
describe('exclusions', () => {
it('lists only icons the policy still rejects', () => {
const openmoji = PACKS.find((p) => p.id === 'openmoji') as PackConfig;
expect(readPackWithCounts(openmoji, ROOT).excluded).toEqual(['resources/assets/svg/files/openmoji-color/travel-places/high-speed-train.svg']);
expect(readPackWithCounts(openmoji, ROOT).excluded.sort()).toEqual([
'resources/assets/svg/files/openmoji-black/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg',
'resources/assets/svg/files/openmoji-color/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg',
]);
});

it('fails on an entry that now passes, or that names no file', () => {
Expand Down
Loading