Skip to content

Pin the flag and openmoji packs at their re-synced commits - #10

Merged
imanimanyara merged 2 commits into
mainfrom
chore/flag-pin-2d7b51c
Nov 5, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
chore/flag-pin-2d7b51c

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Two pin moves in packs.json, one commit each.

  1. flag 67075d3 → 2d7b51c (Re-sync the flags so us and um keep their stars icon-sets-flag#94). The generated US and UM flags carry their stars: dist/data/flag.js now holds 4 marker nodes (us and um, both ratios), which the sanitiser accepts since Accept the SVG marker element so the flags keep their stars #9. Still 542 icons.
  2. openmoji d492519 → 25280ae (the merge of Use upstream's OpenMoji licence text and add an Uncategorised category icon-sets-openmoji#8), with the attribution path changed to resources/assets/svg/licenses/openmoji/LICENSE.txt in the same commit, since Drop the android-vd export (SVG only) #8 replaced the hand-placed LICENSE with upstream's file. 8,568 input SVGs, 8,566 generated:
    • the high-speed-train exclude is removed: it is fixed upstream (Accept display, color and marker-* behind value guards (icon-sets-sync#85 parity) #4), and the build refuses an entry that passes;
    • two new exclude entries, with reasons, for openmoji-{color,black}/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg, which keep an unused xmlns:sodipodi declaration on <svg> that the gate rejects. The fix belongs in icon-sets-sync or upstream.

tests/generate.test.ts takes the new measured count (8,568) and exclusion list, and docs/packs.md the new commits and counts.

Verification

  • typecheck, lint, test (350 passed), build (generator: flag@2d7b51ce0edf: 542 SVGs, openmoji@25280ae1f030: 8568 SVGs (2 excluded)).
  • The attribution gate (tests/generate.test.ts, describe('attribution')): 89 passed, including 14 cases of openmoji ships dist/<flavour>/openmoji/LICENSE.txt.

icon-sets-flag#94 re-synced the flags with <marker> allowed.
icon-sets-openmoji#8 replaced the hand-placed licences/openmoji/LICENSE
with upstream's LICENSE.txt, so the attribution path moves with the pin.
The high-speed-train exclude passes now; two uncategorised flags with an
unused xmlns:sodipodi declaration are excluded instead.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 06:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit 7149b83 into main Nov 5, 2026
8 checks passed
@imanimanyara
imanimanyara deleted the chore/flag-pin-2d7b51c branch November 6, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants