Repository navigation
Pin the flag and openmoji packs at their re-synced commits - #10
Merged
Merged
Conversation
icon-sets-flag#94 re-synced the flags with <marker> allowed.
icon-sets-openmoji#8 replaced the hand-placed licences/openmoji/LICENSE with upstream's LICENSE.txt, so the attribution path moves with the pin. The high-speed-train exclude passes now; two uncategorised flags with an unused xmlns:sodipodi declaration are excluded instead.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pin moves in
packs.json, one commit each.67075d3→2d7b51c(Re-sync the flags so us and um keep their stars icon-sets-flag#94). The generated US and UM flags carry their stars:dist/data/flag.jsnow holds 4markernodes (us and um, both ratios), which the sanitiser accepts since Accept the SVG marker element so the flags keep their stars #9. Still 542 icons.d492519→25280ae(the merge of Use upstream's OpenMoji licence text and add an Uncategorised category icon-sets-openmoji#8), with theattributionpath changed toresources/assets/svg/licenses/openmoji/LICENSE.txtin the same commit, since Drop the android-vd export (SVG only) #8 replaced the hand-placedLICENSEwith upstream's file. 8,568 input SVGs, 8,566 generated:excludeis removed: it is fixed upstream (Accept display, color and marker-* behind value guards (icon-sets-sync#85 parity) #4), and the build refuses an entry that passes;excludeentries, with reasons, foropenmoji-{color,black}/uncategorised/1f3f4-e0063-e0061-e0071-e0063-e007f.svg, which keep an unusedxmlns:sodipodideclaration on<svg>that the gate rejects. The fix belongs in icon-sets-sync or upstream.tests/generate.test.tstakes the new measured count (8,568) and exclusion list, anddocs/packs.mdthe new commits and counts.Verification
typecheck,lint,test(350 passed),build(generator:flag@2d7b51ce0edf: 542 SVGs,openmoji@25280ae1f030: 8568 SVGs (2 excluded)).tests/generate.test.ts,describe('attribution')): 89 passed, including 14 cases ofopenmoji ships dist/<flavour>/openmoji/LICENSE.txt.