Skip to content

Re-sync the flags so us and um keep their stars - #94

Merged
imanimanyara merged 1 commit into
mainfrom
chore/sync-pin-00579ad
Nov 5, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/sync-pin-00579ad

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

The US and UM flags draw their fifty stars as one <marker> repeated by marker-mid. The sync's SVG policy stripped <marker>, so both shipped with an empty canton. icon-sets-sync#91 allows it; this re-syncs on that merge.

  • sync-upstream.yml pins icon-sets-sync 00579ad (the Call the reusable sync-pack workflow from sync-upstream.yml #91 merge), uses: and toolkit-ref together.
  • Re-synced flag-icons 7.6.0 with a binary built from that commit. The dry run reported added=0 removed=0 changed=8: us and um in both ratios regain the <marker> and marker-mid, and bo and je in both ratios keep color="#000" (allowed behind a value guard since icon-sets-sync#85). Nothing else changed.
  • Pixel check of the 4x3 US canton (364x258, white is all channels > 240) in Chromium: 0 before, 11,050 after, matching upstream.
  • tests/Feature/StarredFlagsTest.php fails if us or um loses the marker, its white star path or the marker-mid reference. Against the previous files all 4 cases fail.

The run would also have added resources/assets/svg/licenses/flag-icons/LICENSE, which this pack has never tracked (the licence lives in ATTRIBUTION.md). It is left out of this PR.

Verification

  • pest: 59 passed, 1 skipped. phpstan --debug: no errors. laranail-pint --test: passed.

…tars

The SVG policy now allows <marker>, so the star marker and its
marker-mid reference survive. Pin the sync to the merge and add a test
that fails if us or um lose the marker, the star or the reference.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit 2d7b51c into main Nov 5, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the chore/sync-pin-00579ad branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants