Repository navigation
Re-sync the flags so us and um keep their stars - #94
Merged
Merged
Conversation
…tars The SVG policy now allows <marker>, so the star marker and its marker-mid reference survive. Pin the sync to the merge and add a test that fails if us or um lose the marker, the star or the reference.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The US and UM flags draw their fifty stars as one
<marker>repeated bymarker-mid. The sync's SVG policy stripped<marker>, so both shipped with an empty canton. icon-sets-sync#91 allows it; this re-syncs on that merge.sync-upstream.ymlpins icon-sets-sync00579ad(the Call the reusable sync-pack workflow from sync-upstream.yml #91 merge),uses:andtoolkit-reftogether.added=0 removed=0 changed=8:usandumin both ratios regain the<marker>andmarker-mid, andboandjein both ratios keepcolor="#000"(allowed behind a value guard since icon-sets-sync#85). Nothing else changed.tests/Feature/StarredFlagsTest.phpfails ifusorumloses the marker, its white star path or themarker-midreference. Against the previous files all 4 cases fail.The run would also have added
resources/assets/svg/licenses/flag-icons/LICENSE, which this pack has never tracked (the licence lives inATTRIBUTION.md). It is left out of this PR.Verification
pest: 59 passed, 1 skipped.phpstan --debug: no errors.laranail-pint --test: passed.