Repository navigation
Call the reusable sync-pack workflow from sync-upstream.yml - #91
Merged
Merged
Conversation
Replaces the 185-line copy with a caller of icon-sets-sync's sync-pack.yml pinned to a commit: the toolkit is built from source at that pin instead of docker-built from main, GITHUB_TOKEN keeps contents: read and issues: write only, and a licence change opens an issue. Adds a test pinning the caller's pin, triggers and permissions.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the body of
sync-upstream.ymlwith a caller of icon-sets-sync's reusablesync-pack.yml, pinned to5d70f5d1(main 2026-11-04, with #79 and #80).Closes PK-1 (toolkit pinned, not
main), PK-2 (go buildfrom source withGOPRIVATE/GONOSUMDB, notdocker build), PK-3 (GITHUB_TOKENiscontents: readplusissues: writeonly;statuses: writeis gone), PK-4 (a licence change opens an issue), PK-5 (stale GITHUB_TOKEN comment removed) and PK-6 (the copy is a caller now).Schedule (
45 6 * * 1) andworkflow_dispatchwithforceare kept; there is nopushtrigger.The in-job Pest run and "Sync verification" commit status are dropped: the sync PR is opened with the Refresh Bot token, so the normal CI runs on it.
Tests:
tests/Unit/SyncWorkflowCallerTest.phppins the 40-hex pin, the triggers and the permissions (proved red with a push trigger, an added permission and a@mainpin);symfony/yamljoinsrequire-devfor it.Gates run locally: pest, pint, phpstan.