Skip to content

Call the reusable sync-pack workflow from sync-upstream.yml - #91

Merged
imanimanyara merged 1 commit into
mainfrom
ci/use-sync-pack-workflow
Nov 4, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
ci/use-sync-pack-workflow

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Replaces the body of sync-upstream.yml with a caller of icon-sets-sync's reusable sync-pack.yml, pinned to 5d70f5d1 (main 2026-11-04, with #79 and #80).

Closes PK-1 (toolkit pinned, not main), PK-2 (go build from source with GOPRIVATE/GONOSUMDB, not docker build), PK-3 (GITHUB_TOKEN is contents: read plus issues: write only; statuses: write is gone), PK-4 (a licence change opens an issue), PK-5 (stale GITHUB_TOKEN comment removed) and PK-6 (the copy is a caller now).

  • Schedule (45 6 * * 1) and workflow_dispatch with force are kept; there is no push trigger.

  • The in-job Pest run and "Sync verification" commit status are dropped: the sync PR is opened with the Refresh Bot token, so the normal CI runs on it.

  • Tests: tests/Unit/SyncWorkflowCallerTest.php pins the 40-hex pin, the triggers and the permissions (proved red with a push trigger, an added permission and a @main pin); symfony/yaml joins require-dev for it.

  • Gates run locally: pest, pint, phpstan.

Replaces the 185-line copy with a caller of icon-sets-sync's sync-pack.yml pinned to a commit: the toolkit is built from source at that pin instead of docker-built from main, GITHUB_TOKEN keeps contents: read and issues: write only, and a licence change opens an issue. Adds a test pinning the caller's pin, triggers and permissions.
Copilot AI balanced review requested due to automatic review settings November 4, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@imanimanyara
imanimanyara merged commit 67075d3 into main Nov 4, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the ci/use-sync-pack-workflow branch November 6, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants