Repository navigation
chore(phpstan): analyse at level max - #80
Merged
Merged
Conversation
Raise phpstan.neon.dist from level 0 to max, in icon-sets-bundled's shape. The only finding at max is the two HasIconSetVariants hooks reported as unused, because the trait calls them through static::; they carry one counted, path-scoped ignore with reportUnmatchedIgnoredErrors on, so it fails if either stops occurring. No baseline and no source change. PhpstanLevelTest reads the config and fails when the level is not max or a baseline appears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises PHPStan from level 0 to
max(workstream B of the v0.1.0 fix plan).phpstan.neon.distnow has icon-sets-bundled's shape. The only finding atmaxis the twoHasIconSetVariantshooks reported asmethod.unused, because the trait calls them throughstatic::. They carry one counted, path-scoped ignore withreportUnmatchedIgnoredErrors: true, so it fails if either stops occurring. No baseline, no source change.tests/Unit/PhpstanLevelTest.php(Pest functions only, in its own file) reads the config and fails when the level is notmaxor a baseline appears. Proven red by setting the level to 8 and by adding a baseline file.[Unreleased]entry.Verification
composer update,laranail-pint --test,phpstan analyse(OK, no errors) andpestall pass locally.