Skip to content

chore(phpstan): analyse at level max - #80

Merged
imanimanyara merged 1 commit into
mainfrom
chore/phpstan-max
Oct 30, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/phpstan-max

Conversation

@imanimanyara

Copy link
Copy Markdown
Contributor

Summary

Raises PHPStan from level 0 to max (workstream B of the v0.1.0 fix plan).

  • phpstan.neon.dist now has icon-sets-bundled's shape. The only finding at max is the two HasIconSetVariants hooks reported as method.unused, because the trait calls them through static::. They carry one counted, path-scoped ignore with reportUnmatchedIgnoredErrors: true, so it fails if either stops occurring. No baseline, no source change.
  • New tests/Unit/PhpstanLevelTest.php (Pest functions only, in its own file) reads the config and fails when the level is not max or a baseline appears. Proven red by setting the level to 8 and by adding a baseline file.
  • CHANGELOG [Unreleased] entry.

Verification

composer update, laranail-pint --test, phpstan analyse (OK, no errors) and pest all pass locally.

Raise phpstan.neon.dist from level 0 to max, in icon-sets-bundled's shape. The only finding at max is the two HasIconSetVariants hooks reported as unused, because the trait calls them through static::; they carry one counted, path-scoped ignore with reportUnmatchedIgnoredErrors on, so it fails if either stops occurring. No baseline and no source change.

PhpstanLevelTest reads the config and fails when the level is not max or a baseline appears.
@imanimanyara
imanimanyara merged commit 65faf50 into main Oct 30, 2026
10 checks passed
@imanimanyara
imanimanyara deleted the chore/phpstan-max branch October 30, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant