IBX-12091: Moved JavaScript and TypeScript translation extractors - #3
Merged
Merged
Conversation
mikadamczyk
marked this pull request as ready for review
August 4, 2026 12:42
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
tbialcz and
wiewiurdp
and removed request for
a team
August 4, 2026 12:43
konradoboza
reviewed
Aug 4, 2026
konradoboza
approved these changes
Aug 4, 2026
alongosz
reviewed
Aug 4, 2026
mikadamczyk
commented
Aug 4, 2026
| "require": { | ||
| "php": ">=8.3", | ||
| "ext-json": "*", | ||
| "doctrine/annotations": "^2.0", |
Contributor
Author
There was a problem hiding this comment.
Same reason as Peast. It's used at runtime by the JavaScript extractor. JavaScriptFileVisitor builds a Doctrine\Common\Annotations\DocParser in its constructor and uses it to read @Desc annotations out of the leading comments of a Translator.trans() call, so extraction picks up message descriptions. @Desc is JMSTranslationBundle's own annotation, but the parser that reads it has to be required explicitly
alongosz
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Moved the generic JavaScript and TypeScript translation extractors from Admin UI to the Translations package. The bundle now registers both file visitors with JMSTranslationBundle and provides the PHP and Node dependencies required to run them.
This allows packages to extract frontend translations without registering the complete Admin UI bundle. Integration coverage verifies that the compiled JMS file extractor processes JavaScript and TypeScript fixtures through
IbexaTranslationsBundle.For QA:
No manual QA is required. The change is covered by unit and integration tests.
Documentation:
No documentation changes are required.