IBX-12091: Replaced Admin UI translation test dependency - #339
Merged
Merged
Conversation
|
mikadamczyk
marked this pull request as ready for review
August 6, 2026 11:14
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
tbialcz and
wiewiurdp
and removed request for
a team
August 6, 2026 11:14
konradoboza
approved these changes
Aug 6, 2026
bnowak
approved these changes
Aug 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
The JavaScript and TypeScript translation extractors moved from
ibexa/admin-uitoibexa/translations. This package registered the wholeIbexaAdminUiBundlein its integration test kernel only to get those extractors, so it now depends on the Translations package instead.KnpMenuBundlegoes with it, andsymfony/webpack-encore-bundleis declared explicitly because the kernel registers it and Admin UI used to pull it in. No translation files change.Verified with
ibexa/admin-uinot installed at all: the integration suite passes, and removing the registration makesTranslationTestfail on theck_editormessages that exist only in JavaScript sources.For QA:
No manual QA. Covered by the existing
TranslationTest.Documentation:
Not required.