Skip to content

IBX-12091: Added typescript-estree to frontend dependencies - #255

Merged
alongosz merged 1 commit into
masterfrom
IBX-12091-typescript-estree
Aug 4, 2026
Merged

alongosz merged 1 commit into
masterfrom
IBX-12091-typescript-estree

Conversation

@mikadamczyk

@mikadamczyk mikadamczyk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-12091

Related PRs:

Description:

ibexa/admin-ui extracts translations from TypeScript with a Node script importing @typescript-eslint/typescript-estree. Composer cannot install npm packages, so bin/console translation:extract currently fails in a freshly installed project.
Adding the package to encore/package.json makes the documented installation provision it: post-update-cmd runs auto-scripts, which already runs yarn install. Node then resolves the parser from the project's node_modules.

For QA:

Documentation:

@github-actions

Copy link
Copy Markdown

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-255

before executing the recipes.

@sonarqubecloud

Copy link
Copy Markdown

@mikadamczyk
mikadamczyk marked this pull request as ready for review July 30, 2026 09:36
@mikadamczyk
mikadamczyk requested review from a team July 30, 2026 09:36
@alongosz
alongosz merged commit 492fa16 into master Aug 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants