IBX-10684: Document translation management - #3249
Conversation
Co-Authored-By: dabrt <dabrt@users.noreply.github.com> Co-Authored-By: Marek Nocoń <mnocon@users.noreply.github.com>
Co-authored-by: Tomasz Kryszan <tomasz.kryszan@ibexa.co>
mnocon
left a comment
There was a problem hiding this comment.
Review without the "Extend..." article (will do the review of it soon)
Summary
Errors per inputErrors in site/administration/configuration/configuration/index.html
Errors in site/api/php_api/php_api/index.html
Errors in site/infrastructure_and_maintenance/cache/http_cache/reverse_proxy/index.html
Errors in site/multisite/translations_management/configure_translations_management/index.html
Errors in site/multisite/translations_management/translate_with_cli/index.html
Errors in site/multisite/translations_management/translations_management_guide/index.html
Errors in site/permissions/custom_policies/index.html
Errors in site/release_notes/ibexa_dxp_v4.6/index.html
Errors in site/release_notes/ibexa_dxp_v5.0/index.html
Errors in site/search/search_criteria_and_sort_clauses/index.html
Redirects per inputRedirects in site/administration/back_office/customize_search_suggestion/index.html
Redirects in site/administration/project_organization/project_organization/index.html
Redirects in site/api/php_api/php_api/index.html
Redirects in site/api/rest_api/extending_rest_api/creating_new_rest_resource/index.html
Redirects in site/commerce/checkout/checkout/index.html
Redirects in site/commerce/checkout/configure_checkout/index.html
Redirects in site/content_management/field_types/type_and_value/index.html
Redirects in site/release_notes/ez_platform_v3.0_deprecations/index.html |
There was a problem hiding this comment.
SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
julitafalcondusza
left a comment
There was a problem hiding this comment.
Check my comments.
There was a problem hiding this comment.
"Benefits" section is missing.
There is a list of challenges at the top of the article, but the corresponding list of benefits is missing at the end. Adding one would help summarize the feature and highlight its value.
julitafalcondusza
left a comment
There was a problem hiding this comment.
Conditional approve, after release please add mentioned "Benefits" section and update the diagram.
mnocon
left a comment
There was a problem hiding this comment.
Two small things to follow-up with
| ``` yaml | ||
| [[= include_code('code_samples/translations_management/config/services.yaml', 1, 1) =]] | ||
| [[= include_code('code_samples/translations_management/config/services.yaml', 15, 27) =]] | ||
| [[= include_code('code_samples/translations_management/config/services.yaml', 15, 23) =]] |
code_samples/ change report
|

Document translation management
Checklist