-
Notifications
You must be signed in to change notification settings - Fork 19
IBX-12271: Migrated Solr image to version 10.0 #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barw4
wants to merge
1
commit into
6.0
Choose a base branch
from
ibx-12271-solr-10-docker-image
base: 6.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| FROM alpine:3.18.5 as builder | ||
| FROM alpine:3.22 as builder | ||
| RUN apk add --no-cache --upgrade bash git curl | ||
| RUN adduser --disabled-password user | ||
| USER user | ||
| WORKDIR /home/user | ||
| RUN git clone --depth=1 https://github.com/ibexa/solr.git solr | ||
| RUN ./solr/bin/generate-solr-config.sh --destination-dir=config --solr-version=8.6.3 | ||
| RUN git clone --depth=1 --branch 6.0 https://github.com/ibexa/solr.git solr | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can |
||
| RUN ./solr/bin/generate-solr-config.sh --destination-dir=config --solr-version=10.0.0 | ||
|
|
||
| FROM solr:8.6.3 | ||
| LABEL org.opencontainers.image.source=https://github.com/ibexa/core/blob/main/docker/solr/Dockerfile | ||
| FROM solr:10.0.0 | ||
| LABEL org.opencontainers.image.source=https://github.com/ibexa/core/blob/6.0/docker/solr/Dockerfile | ||
| LABEL org.opencontainers.image.description="Configured Ibexa Solr Bundle image, created by 'Build and publish Solr Docker image' GHA workflow" | ||
| LABEL org.opencontainers.image.licenses=GPL-2.0-only | ||
| USER root | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be confusing. I'm assuming
latestwill still exist from the last build, but it won't be "latest" anymore. Is it possible to build both$IMAGE_TAGandlatestor alias one to another.This also means that we should build on 5.0 a// ah, I see already planned as follow-ups5.0version and on4.6a4.6version, though I expect them to be the same.Or do you also plan to align
latestonly after fixing 4.6 and 5.0? Given the use it, it would make sense.