Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 14, 2026 18:55
barw4
force-pushed
the
ibx-12271-solr-10-docker-image
branch
from
September 14, 2026 19:10
d0b689e to
f4755d5
Compare
|
konradoboza
approved these changes
Sep 15, 2026
bnowak
approved these changes
Sep 15, 2026
alongosz
reviewed
Sep 17, 2026
|
|
||
| - name: Build Solr image | ||
| run: docker build -t "$IMAGE_NAME:latest" docker/solr | ||
| run: docker build -t "$IMAGE_NAME:$IMAGE_TAG" docker/solr |
Member
There was a problem hiding this comment.
This is going to be confusing. I'm assuming latest will still exist from the last build, but it won't be "latest" anymore. Is it possible to build both $IMAGE_TAG and latest or alias one to another.
This also means that we should build on 5.0 a // ah, I see already planned as follow-ups5.0 version and on 4.6 a 4.6 version, though I expect them to be the same.
Or do you also plan to align latest only after fixing 4.6 and 5.0? Given the use it, it would make sense.
| WORKDIR /home/user | ||
| RUN git clone --depth=1 https://github.com/ibexa/solr.git solr | ||
| RUN ./solr/bin/generate-solr-config.sh --destination-dir=config --solr-version=8.6.3 | ||
| RUN git clone --depth=1 --branch 6.0 https://github.com/ibexa/solr.git solr |
Member
There was a problem hiding this comment.
Can 6.0 be taken from env/ARGS at runtime?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Rollout plan (lockstep with ibexa/solr#118)
Order matters — core CI is red between steps 2 and 5, keep the window short.
ibexa/solr# (Solr 10 support, targets
6.0) and this PR.Note: this PR's
solr-integrationjob is expected to fail until step 3 —the
ghcr.io/ibexa/core/solr:6.0image does not exist yet.6.0. From this momentibexa/solr's HEADbranch (
6.0) only supports Solr 10, and core6.0CI turns red.(
gha-docker-solr.yaml) on THIS branch (ibx-12271-solr-10-docker-image).It clones ibexa/solr
6.0(now Solr 10), builds the image fromsolr:10.0.0, gates it oncomposer test-integration-solr, and pushesghcr.io/ibexa/core/solr:6.0.solr-integrationnow pulls the:6.0imageand should be green.
6.0CI is green again.Follow-ups (separate PRs)
git cloneindocker/solr/Dockerfileon core4.6and5.0to the matching ibexa/solr branch (
--branch 4.6/--branch 5.0).Those Dockerfiles clone the repo's HEAD branch (=
6.0), so theirimage rebuild will fail once IBX-12271: Implemented Solr 10 support solr#118 merges.
docker/solr+gha-docker-solr.yamlfrom core toibexa/solr, since the image content is generated from that repo anyway.
For QA:
Documentation: