IBX-12654: Added ibexa/phpstan and fixed dynamic calls to static methods

composer.json

@@ -31,6 +31,7 @@
         "ibexa/doctrine-schema": "~6.0.x-dev",
         "ibexa/http-cache": "~6.0.x-dev",
         "ibexa/notifications": "~6.0.x-dev",
+        "ibexa/phpstan": "~6.0.x-dev",
         "ibexa/rector": "~6.0.x-dev",
         "ibexa/rest": "~6.0.x-dev",
         "ibexa/test-core": "~6.0.x-dev",

phpstan.neon.dist

@@ -1,6 +1,7 @@
 includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-symfony/extension.neon
+    - vendor/ibexa/phpstan/extension.neon
     - phpstan-baseline.neon
 
 parameters:

src/lib/FieldType/Mapper/UserAccountFieldValueFormMapper.php

@@ -78,7 +78,7 @@ public function getModelTransformerForTranslation(FieldDefinition $fieldDefiniti
             static function (ApiUserValue $data): UserAccountFieldData {
                 return new UserAccountFieldData($data->login, null, $data->email, $data->enabled);
             },
-            static function (UserAccountFieldData $submittedData) use ($fieldDefinition) {
+            static function (UserAccountFieldData $submittedData) use ($fieldDefinition): ApiUserValue {
                 /** @var \Ibexa\Core\FieldType\User\Value $userValue */
                 $userValue = clone $fieldDefinition->defaultValue;
 

tests/lib/Event/FormActionEventTest.php

@@ -18,7 +18,7 @@ final class FormActionEventTest extends TestCase
 {
     public function testConstruct(): void
     {
-        $form = $this->createStub(FormInterface::class);
+        $form = self::createStub(FormInterface::class);
         $data = new stdClass();
         $clickedButton = 'fooButton';
         $options = ['languageCode' => 'eng-GB', 'foo' => 'bar'];
@@ -33,7 +33,7 @@ public function testConstruct(): void
     public function testEventDoesntHaveResponse(): void
     {
         $event = new FormActionEvent(
-            $this->createStub(FormInterface::class),
+            self::createStub(FormInterface::class),
             new stdClass(),
             'fooButton'
         );
@@ -44,7 +44,7 @@ public function testEventDoesntHaveResponse(): void
     public function testEventSetResponse(): void
     {
         $event = new FormActionEvent(
-            $this->createStub(FormInterface::class),
+            self::createStub(FormInterface::class),
             new stdClass(),
             'fooButton'
         );
@@ -63,7 +63,7 @@ public function testGetOption(): void
         $options = ['languageCode' => 'eng-GB', 'foo' => 'bar', 'obj' => $objectOption];
 
         $event = new FormActionEvent(
-            $this->createStub(FormInterface::class),
+            self::createStub(FormInterface::class),
             new stdClass(),
             'fooButton',
             $options

tests/lib/FieldType/DataTransformer/FieldValueTransformerTest.php

@@ -32,7 +32,7 @@ public function testTransformNull(): void
 
     public function testTransform(): void
     {
-        $value = $this->createStub(Value::class);
+        $value = self::createStub(Value::class);
         $valueHash = ['lorem' => 'Lorem ipsum dolor...'];
 
         $fieldType = $this->createMock(FieldType::class);
@@ -49,7 +49,7 @@ public function testTransform(): void
 
     public function testReverseTransformNull(): void
     {
-        $emptyValue = $this->createStub(Value::class);
+        $emptyValue = self::createStub(Value::class);
 
         $fieldType = $this->createMock(FieldType::class);
         $fieldType
@@ -68,7 +68,7 @@ public function testReverseTransformNull(): void
     public function testReverseTransform(): void
     {
         $value = 'Lorem ipsum dolor...';
-        $expected = $this->createStub(Value::class);
+        $expected = self::createStub(Value::class);
 
         $fieldType = $this->createMock(FieldType::class);
         $fieldType

tests/lib/FieldType/FieldTypeFormMapperDispatcherTest.php

@@ -42,7 +42,7 @@ public function testMapFieldValue(): void
             'fieldDefinition' => new FieldDefinition(['fieldTypeIdentifier' => 'first_type']),
         ]);
 
-        $formMock = $this->createStub(FormInterface::class);
+        $formMock = self::createStub(FormInterface::class);
 
         $this->fieldTypeAliasResolverMock
             ->method('resolveIdentifier')

tests/lib/FieldType/Mapper/BaseMapperTestCase.php

@@ -35,15 +35,15 @@ protected function setUp(): void
         $this->fieldTypeService = $this->createMock(FieldTypeService::class);
         $this->fieldTypeService
             ->method('getFieldType')
-            ->willReturn($this->createStub(FieldType::class));
+            ->willReturn(self::createStub(FieldType::class));
 
         $this->config = $this->createMock(FormConfigInterface::class);
         $this->fieldForm = $this->createMock(FormInterface::class);
         $formFactory = $this->createMock(FormFactoryInterface::class);
         $formFactory
             ->expects(self::once())
             ->method('createBuilder')
-            ->willReturn($this->createStub(FormBuilder::class));
+            ->willReturn(self::createStub(FormBuilder::class));
 
         $this->config
             ->expects(self::once())

tests/lib/Form/EventSubscriber/FixUrlProtocolListenerTest.php

@@ -29,7 +29,7 @@ final class FixUrlProtocolListenerTest extends TestCase
     #[DataProvider('provideUrlCases')]
     public function testUrlProtocolHandling(?string $inputData, ?string $expectedData, string $defaultProtocol = 'https'): void
     {
-        $form = $this->createStub(FormInterface::class);
+        $form = self::createStub(FormInterface::class);
         $listener = new FixUrlProtocolListener($defaultProtocol);
 
         $event = new FormEvent($form, $inputData);

tests/lib/Form/Processor/ContentFormProcessorTest.php

@@ -108,10 +108,10 @@ public function testProcessPublish(
 
         // The deferred (async) redirect resolves its location from the content tree root config
         // and the location lookup.
-        $configResolver = $this->createStub(ConfigResolverInterface::class);
+        $configResolver = self::createStub(ConfigResolverInterface::class);
         $configResolver->method('getParameter')->willReturn(self::TREE_ROOT_LOCATION_ID);
 
-        $locationService = $this->createStub(LocationService::class);
+        $locationService = self::createStub(LocationService::class);
         $locationService->method('loadLocation')->willReturn(
             new Location([
                 'id' => self::TREE_ROOT_LOCATION_ID,
@@ -242,16 +242,16 @@ private function createDraft(?int $mainLocationId, int $status): Content
             'status' => $status,
         ]);
 
-        $versionInfo = $this->createStub(VersionInfo::class);
+        $versionInfo = self::createStub(VersionInfo::class);
         $versionInfo->method('getInitialLanguage')->willReturn(
             new Language(['languageCode' => self::LANGUAGE_CODE])
         );
         $versionInfo->method('getContentInfo')->willReturn($contentInfo);
 
-        $draft = $this->createStub(Content::class);
+        $draft = self::createStub(Content::class);
         $draft->method('getVersionInfo')->willReturn($versionInfo);
         $draft->method('getContentInfo')->willReturn($contentInfo);
-        $draft->method('getContentType')->willReturn($this->createStub(ContentType::class));
+        $draft->method('getContentType')->willReturn(self::createStub(ContentType::class));
 
         return $draft;
     }
@@ -265,7 +265,7 @@ private function createPublishedContent(): Content
             'status' => ContentInfo::STATUS_PUBLISHED,
         ]);
 
-        $publishedContent = $this->createStub(Content::class);
+        $publishedContent = self::createStub(Content::class);
         $publishedContent->method('getContentInfo')->willReturn($contentInfo);
         $publishedContent->method('getId')->willReturn(self::CONTENT_ID);
 
@@ -293,13 +293,13 @@ private function createCreateData(): ContentCreateData
      */
     private function createForm(?string $redirectUrlAfterPublish = null): FormInterface
     {
-        $formConfig = $this->createStub(FormConfigInterface::class);
+        $formConfig = self::createStub(FormConfigInterface::class);
         $formConfig->method('getOption')->willReturn(self::LANGUAGE_CODE);
 
-        $redirectUrlField = $this->createStub(FormInterface::class);
+        $redirectUrlField = self::createStub(FormInterface::class);
         $redirectUrlField->method('getData')->willReturn($redirectUrlAfterPublish);
 
-        $form = $this->createStub(FormInterface::class);
+        $form = self::createStub(FormInterface::class);
         $form->method('getConfig')->willReturn($formConfig);
         $form->method('offsetGet')->willReturn($redirectUrlField);
 

tests/lib/Validator/Constraints/PasswordTest.php

@@ -47,7 +47,7 @@ public function testGetTargets(): void
 
     public function testNamedArguments(): void
     {
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
         $payload = new \stdClass();
 
         $constraint = new Password(

tests/lib/Validator/Constraints/PasswordValidatorTest.php

@@ -54,15 +54,15 @@ public function testValidateShouldBeSkipped(mixed $value): void
     public function testValid(): void
     {
         $password = 'pass';
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
 
         $this->userService
             ->expects(self::once())
             ->method('validatePassword')
-            ->willReturnCallback(function ($actualPassword, $actualContext) use ($password, $contentType): array {
-                $this->assertEquals($password, $actualPassword);
-                $this->assertInstanceOf(PasswordValidationContext::class, $actualContext);
-                $this->assertSame($contentType, $actualContext->contentType);
+            ->willReturnCallback(static function ($actualPassword, $actualContext) use ($password, $contentType): array {
+                self::assertEquals($password, $actualPassword);
+                self::assertInstanceOf(PasswordValidationContext::class, $actualContext);
+                self::assertSame($contentType, $actualContext->contentType);
 
                 return [];
             });
@@ -76,18 +76,18 @@ public function testValid(): void
 
     public function testInvalid(): void
     {
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
         $password = 'pass';
         $errorParameter = 'foo';
         $errorMessage = 'error';
 
         $this->userService
             ->expects(self::once())
             ->method('validatePassword')
-            ->willReturnCallback(function ($actualPassword, $actualContext) use ($password, $contentType, $errorMessage, $errorParameter): array {
-                $this->assertEquals($password, $actualPassword);
-                $this->assertInstanceOf(PasswordValidationContext::class, $actualContext);
-                $this->assertSame($contentType, $actualContext->contentType);
+            ->willReturnCallback(static function ($actualPassword, $actualContext) use ($password, $contentType, $errorMessage, $errorParameter): array {
+                self::assertEquals($password, $actualPassword);
+                self::assertInstanceOf(PasswordValidationContext::class, $actualContext);
+                self::assertSame($contentType, $actualContext->contentType);
 
                 return [
                     new ValidationError($errorMessage, null, ['%foo%' => $errorParameter]),

tests/lib/Validator/Constraints/UserAccountPasswordTest.php

@@ -40,7 +40,7 @@ public function testGetTargets(): void
 
     public function testNamedArguments(): void
     {
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
 
         $constraint = new UserAccountPassword(contentType: $contentType);
 

tests/lib/Validator/Constraints/UserAccountPasswordValidatorTest.php

@@ -63,15 +63,15 @@ public static function dataProviderForValidateNotSupportedValueType(): array
     public function testValid(): void
     {
         $userAccount = new UserAccountFieldData('user', 'pass', 'user@ibexa.co');
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
 
         $this->userService
             ->expects(self::once())
             ->method('validatePassword')
-            ->willReturnCallback(function ($actualPassword, $actualContext) use ($userAccount, $contentType): array {
-                $this->assertEquals($userAccount->password, $actualPassword);
-                $this->assertInstanceOf(PasswordValidationContext::class, $actualContext);
-                $this->assertSame($contentType, $actualContext->contentType);
+            ->willReturnCallback(static function ($actualPassword, $actualContext) use ($userAccount, $contentType): array {
+                self::assertEquals($userAccount->password, $actualPassword);
+                self::assertInstanceOf(PasswordValidationContext::class, $actualContext);
+                self::assertSame($contentType, $actualContext->contentType);
 
                 return [];
             });
@@ -85,18 +85,18 @@ public function testValid(): void
 
     public function testInvalid(): void
     {
-        $contentType = $this->createStub(ContentType::class);
+        $contentType = self::createStub(ContentType::class);
         $userAccount = new UserAccountFieldData('user', 'pass', 'user@ibexa.co');
         $errorParameter = 'foo';
         $errorMessage = 'error';
 
         $this->userService
             ->expects(self::once())
             ->method('validatePassword')
-            ->willReturnCallback(function ($actualPassword, $actualContext) use ($userAccount, $contentType, $errorMessage, $errorParameter): array {
-                $this->assertEquals($userAccount->password, $actualPassword);
-                $this->assertInstanceOf(PasswordValidationContext::class, $actualContext);
-                $this->assertSame($contentType, $actualContext->contentType);
+            ->willReturnCallback(static function ($actualPassword, $actualContext) use ($userAccount, $contentType, $errorMessage, $errorParameter): array {
+                self::assertEquals($userAccount->password, $actualPassword);
+                self::assertInstanceOf(PasswordValidationContext::class, $actualContext);
+                self::assertSame($contentType, $actualContext->contentType);
 
                 return [
                     new ValidationError($errorMessage, null, ['%foo%' => $errorParameter]),