IBX-12654: Added ibexa/phpstan and fixed dynamic calls to static methods - #126
Merged
wiewiurdp merged 3 commits intoSep 23, 2026
Conversation
|
bnowak
marked this pull request as ready for review
September 23, 2026 10:32
konradoboza
approved these changes
Sep 23, 2026
wiewiurdp
approved these changes
Sep 23, 2026
wiewiurdp
deleted the
IBX-12654-added-ibexa-phpstan-and-fixed-dynamic-calls-to-static-methods
branch
September 23, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Adds
ibexa/phpstanas a dev dependency and includes its extension in the PHPStan configuration.Replaces dynamic calls to static methods (
$this->assertX(), static test helpers, ...) withself::/ClassName::calls: 38 calls in 10 files. ThestaticMethod.dynamicCallstrict rule itself is enabled in the linked ibexa/phpstan PR; this PR keeps CI green once that is released.Also fixes what the existing
ibexa/phpstanrules report: 1 closure got a return type (Ibexa.requireClosureReturnType) inUserAccountFieldValueFormMapper::getModelTransformerForTranslation().Known CI note: SonarCloud's "duplication on new code" gate fails (9.3% > 3%) on
tests/lib/Validator/Constraints/PasswordValidatorTest.phpandtests/lib/Validator/Constraints/UserAccountPasswordValidatorTest.php. These are pre-existing, near-identical PHPUnit test classes; this PR only changes$this->assertX()/$this->createStub()toself::inside already-duplicated closures. SonarCloud attributes the whole pre-existing duplicated block as "new code" whenever any line in it changes. All other CI jobs are green. Not refactoring the test fixtures here (out of scope, risky).For QA:
No functional change. CI (PHPStan, code style, unit tests) is the verification.
Documentation:
No client-facing impact.