IBX-12046: Removed Symfony and template deprecations triggered by admin-ui - #2112
Conversation
a2aa667 to
6d7e515
Compare
7f2b6a6 to
5fb9e5e
Compare
6d7e515 to
8250487
Compare
9a13b36 to
a188335
Compare
93c33f2 to
a5fc602
Compare
…DateIntervalType form type
a5fc602 to
ea96fb2
Compare
| if ($container->hasExtension('twig_component')) { | ||
| $container->prependExtensionConfig('twig_component', [ | ||
| 'anonymous_template_directory' => 'components/', | ||
| 'defaults' => [], | ||
| ]); | ||
| } |
There was a problem hiding this comment.
Isn't this set up by Symfony recipe? If so, then we should just add it onto the test setup instead of prepending it.
There was a problem hiding this comment.
Actually, I wanted to move it to our twig compoments, but i guess we can override it at recipe level as well, will check.
but it will prolly pop up on integration tests, so its needs to be added somewhere there as well.
There was a problem hiding this comment.
As this is just to clean up our baseline from integration tests deprecations I had moved it into ibexa/test-core@d8e42da
on project level lets leave it to customers or original recipes. (I even think it is already there)
ea96fb2 to
ca5f650
Compare
|



Related PRs:
6.0.twig_componentin the test kernel.Description:
A Symfony 7.x deprecation that admin-ui causes in every kernel loading it, and which therefore sits in the integration baselines of 10–11 consumer repositories:
Ibexa\AdminUi\Form\Type\Search\DateIntervalType: ~defines a service for a class that does not exist (the real type isDate\DateIntervalType, which is whatSearchType/TrashSearchTypeuse), triggering "Service id … looks like a FQCN but no corresponding class or interface exists". The definition is dead and was removed.admin-ui's own
phpunit.integration.baseline.xml(the integration gate added in #2100) loses exactly theSearch\DateIntervalTypeentry; nothing added (PHP 8.3 + 8.4, SQLite/MySQL/PostgreSQL give identical baselines). The unitphpunit.baseline.xmlis unchanged (no kernel boots there). Cross-checked in scheduler with this branch installed: its regenerated integration baseline loses theDateIntervalTypeentry, nothing added.The
twig_componentdefaults (anonymous_template_directory,defaults) come from the symfony/ux-twig-component Flex recipe in projects; test kernels get them from ibexa/test-core#58 instead, so their two baseline entries stay here until that merges.Also fixed the three template deprecations the integration gate (#2100) reports from
TranslationTest— their messages carry the absolute template path, so #2100 baselines them with the CI checkout path; this PR removes those 3 entries again:useandmacrotags to the template root (Twig 3.28).form_fields.html.twig: theuseinsidecontent_type_meta_field_definition_enabled_rowduplicated the root-leveluseof the same template and was dropped.modal_add_custom_url.html.twig: theinfo_textmacro moved to a newcontent/tab/url/macros.html.twig(same pattern asdashboard/macros.html.twig,content_type/macros.html.twig), imported inside theembed— neitherimport _selfinside anembed(refers to the embedded template) nor a root-level import (not visible in the embed's scope) works.ibexa_twig_component_groupinstead of the deprecatedibexa_render_component_group. The two read different registries:fieldtype-richtext-rteregisters its presence list incontent-form-edit-header-info-bar-extraswith theibexa.twig.componenttag, which the old function never read, so it was not rendered.For QA:
No functional change. Verified locally with a fresh
composer updateon PHP 8.3 and 8.4:test-unitand the gatedtest-integrationexit 0 (8.4 also against PostgreSQL 10), PHPStan, deptrac and php-cs-fixer clean.Documentation:
N/A