Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
IbexaAdminUiExtension; this one covers kernels that registerTwigComponentBundlewithout admin-ui.Description:
symfony/ux-twig-component deprecates leaving
twig_component.defaultsandtwig_component.anonymous_template_directoryunset. admin-ui#2112 prepends them, but kernels that registerIbexaTwigComponentsBundle+TwigComponentBundlewithoutIbexaAdminUiBundle(e.g. ibexa/checkout's integration kernel) never run that prepend, so both deprecations stay in their baselines.IbexaTwigComponentsExtension::prepend()now prepends the same values (anonymous_template_directory: components/,defaults: []), gated on thetwig_componentextension being registered. Where both bundles are registered the two prepends push identical config.For QA:
No functional change. PHP 8.3 and 8.4, fresh
composer update: unit and integration suites exit 0, PHPStan and code style clean; new unit tests cover both the registered and unregisteredtwig_componentcases. Consumer check in ibexa/checkout with this change installed: bothtwig_componentdeprecations are gone from its integration run, nothing new.Documentation:
N/A