Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ async function listLocaleJson(localeArr) {
}))
}

build(configFactory({
await build(configFactory({
input: './src/index.js',
fileName: './dayjs.min.js'
}))
Expand Down
44 changes: 44 additions & 0 deletions test/build/mainBuildAwait.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
describe('main bundle build ordering', () => {
beforeEach(() => {
jest.resetModules()
})

afterEach(() => {
jest.restoreAllMocks()
})

it('finishes the main Rollup build before writing the locale manifest', async () => {
let resolveRollup
let resolveManifest
const manifestWritten = new Promise((resolve) => {
resolveManifest = resolve
})
const writeFile = jest.fn((file, contents, encoding, callback) => {
callback()
resolveManifest()
})

jest.doMock('rollup', () => ({
rollup: () => new Promise((resolve) => {
resolveRollup = () => resolve({ write: () => Promise.resolve() })
})
}))
jest.doMock('../../build/rollup.config', () => config => config)
jest.doMock('ncp', () => ({ ncp: (source, destination, callback) => callback() }))
jest.doMock('fs', () => ({
readdir: (directory, callback) => callback(null, []),
readFile: (file, encoding, callback) => callback(null, ''),
writeFile
}))

require('../../build') // eslint-disable-line global-require

await new Promise(resolve => setImmediate(resolve))
expect(resolveRollup).toEqual(expect.any(Function))
expect(writeFile).not.toHaveBeenCalled()

resolveRollup()
await manifestWritten
expect(writeFile).toHaveBeenCalledTimes(1)
})
})